dup() -> dup2()
gcc would warn about an unused result. We know it is 0 and dup() can't fail in these circumstances, as we closed fd0 previously. Using dup2() to do the same saves one line and shuts gcc up, bringing us a clean build back.
This commit is contained in:
		
							
								
								
									
										3
									
								
								st.c
									
									
									
									
									
								
							
							
						
						
									
										3
									
								
								st.c
									
									
									
									
									
								
							| @@ -1430,8 +1430,7 @@ ttynew(void) | |||||||
| 	if (opt_line) { | 	if (opt_line) { | ||||||
| 		if ((cmdfd = open(opt_line, O_RDWR)) < 0) | 		if ((cmdfd = open(opt_line, O_RDWR)) < 0) | ||||||
| 			die("open line failed: %s\n", strerror(errno)); | 			die("open line failed: %s\n", strerror(errno)); | ||||||
| 		close(0); | 		dup2(cmdfd, 0); | ||||||
| 		dup(cmdfd); |  | ||||||
| 		stty(); | 		stty(); | ||||||
| 		return; | 		return; | ||||||
| 	} | 	} | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user