Commit Graph
100 Commits
Author SHA1 Message Date
Leonardo Hernández Hernández 433385f7f1 do not arrange monitor if it's disabled (wlroots!4520)
This causes us to send negative values to xdg-configures (e.g a bug in our end)

References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4520
(cherry picked from commit 4043fc3093)
2024-01-24 13:36:46 -06:00
Leonardo Hernández Hernández 6c8be38ec4 drop unused variable 2024-01-15 02:19:02 +00:00
Leonardo Hernández Hernández 417e37f988 request description before logs 2024-01-15 02:15:54 +00:00
Leonardo Hernández Hernández a1f3e25c35 turn on -Wfloat-conversion 2024-01-15 02:09:18 +00:00
Leonardo Hernández Hernández 0151bd48dd turn on -Wsign-compare 2024-01-15 02:09:18 +00:00
Leonardo Hernández Hernández ec557f253b clarify the code will be kept as small as possible 2024-01-12 22:34:09 -06:00
Leonardo Hernández Hernández a73afc66ab drop SLOC limit 2024-01-10 20:50:34 -06:00
Leonardo Hernández Hernández f5b046ce9e prefer functionality over philosophy 2024-01-10 00:20:11 -06:00
Leonardo Hernández Hernández 6340989c8e add acknowledgment to djpohly 2024-01-10 00:17:06 -06:00
Leonardo Hernández Hernández f3c4f72314 fix posible NULL-dereference in wl_surface.commit handler 2024-01-01 00:51:01 -06:00
Leonardo Hernández Hernández 6cbf8e9b80 unset DISPLAY before setting up xwayland 2023-12-27 11:19:03 -06:00
Leonardo Hernández Hernández d13015381b only execute the first keybinding 2023-12-27 11:18:24 -06:00
Leonardo Hernández Hernández e277d84c51 more style fixes
missed from the previous iteration
2023-12-27 11:17:52 -06:00
Leonardo Hernández Hernández 1f0afcfc28 create a wlr_keyboard_group for virtual keyboards
Fixes: https://codeberg.org/dwl/dwl/issues/554
2023-12-25 21:19:59 -06:00
Leonardo Hernández Hernández 23fd312409 fix typo
Fixes: 7afdc191fe
Thanks to: David Donahue <[email protected]>
2023-12-18 14:08:09 -06:00
Leonardo Hernández Hernández e39d931430 tie xdg_toplevel_decorations to Client
a xdg_toplevel can only have one xdg_toplevel_decoration so there is no need to
have a new struct for decorations
2023-12-18 12:59:47 -06:00
Leonardo Hernández Hernández 396840cdf2 Revert "nuke CSDs, hopefully for good!"
The compositor must respond to the client requesting a change to the decoration
mode, it does not matter if the compositor chooses a different mode.

This reverts commit 9071ce6c84.
2023-12-18 12:56:20 -06:00
Leonardo Hernández Hernández a71b368483 Revert "remove typedef Decoration"
This reverts commit d1ff1e6f75.
2023-12-18 12:56:19 -06:00
Leonardo Hernández Hernández 7afdc191fe style fixes 2023-12-17 21:42:50 +00:00
Leonardo Hernández Hernández fa660fb61e check toplevel resources
it's just a aesthetic change
2023-12-12 22:21:32 -06:00
Leonardo Hernández Hernández 49bfe92703 merge X11Managed and X11Unmanaged into X11
now that client_is_unmanaged() checks the wlr struct we don't need to keep
track of it ourselves
2023-12-10 23:46:49 -06:00
Leonardo Hernández Hernández c88960751d check if a client is unmanaged checking the o-r flag
it may change at any moment and I don't really want to add a listener for it
2023-12-10 23:46:40 -06:00
Leonardo Hernández Hernández 9c5bdcfbe8 do not blindly try to send motion events when pointer button is pressed
we don't have to do this if the surface is the same
2023-12-10 23:27:59 -06:00
Leonardo Hernández Hernández 1884a07646 sort LISTEN calls in createnotify{,x11} 2023-12-07 22:40:59 -06:00
Leonardo Hernández Hernández 79c51a4584 use the same style for urgent() and sethints() 2023-12-07 22:37:35 -06:00
Leonardo Hernández Hernández f5d839844d remove an unneeded cast in createpointer() 2023-12-07 22:37:00 -06:00
Leonardo Hernández Hernández e03896b4d6 avoid duplication of lines
the output state is copied when creating a output configuration head
2023-12-07 22:18:49 -06:00
Leonardo Hernández Hernández e7e84b1083 add explanation about why we try to re-apply the gamma LUT on output changes 2023-12-07 22:17:48 -06:00
Leonardo Hernández Hernández 9694477b2f relax a bit the line length limit 2023-12-07 22:16:13 -06:00
Leonardo Hernández Hernández 6a15167754 add a blank line to improve readability 2023-12-07 22:15:42 -06:00
Leonardo Hernández Hernández e5e2d1c28f use (struct wlr_box){0} to empty the Monitor areas 2023-12-07 22:04:24 -06:00
Leonardo Hernández Hernández bdbfb45d66 copy layout symbol when matching a MonitorRule 2023-12-07 21:51:24 -06:00
Leonardo Hernández Hernández 50ea84c5f6 remove extra blank line 2023-12-07 21:49:26 -06:00
Leonardo Hernández Hernández 472a31b5a4 LayerSurface::link -> LayerSurface.link 2023-12-07 21:48:56 -06:00
Leonardo Hernández Hernández a760757b82 set the correct border color when mapping a client 2023-12-07 21:44:53 -06:00
Leonardo Hernández Hernández 80c9ad12ba reduce calls to client_get_geometry 2023-12-07 21:43:48 -06:00
Leonardo Hernández Hernández 7341d047da add a note about not removing the default rule
Closes: https://codeberg.org/dwl/dwl/issues/527
2023-12-07 14:20:49 -06:00
Leonardo Hernández Hernández 393078d80c store the layersurface pointer in l->popups->node.data as well 2023-12-07 14:19:09 -06:00
Leonardo Hernández Hernández 28ec843aee make sure popups of a layer surface are in the correct layer
previously it worked because we checked in every commit the layer
in a353eee2ca and
b100b446b8
we changed the way it's handled and now if the layer surface does not change
the layer we don't it either. meaning that if it was created in the bottom
layer and did not change the layer the popups would show behind xdg clients
2023-12-07 14:19:02 -06:00
Leonardo Hernández Hernández 2b3504e439 sort #includes 2023-12-01 21:35:50 -06:00
Leonardo Hernández Hernández 5f7d396996 don't return early if the first output commit fails 2023-11-30 22:39:03 -06:00
Leonardo Hernández Hernández 901d2e2d9d check failure of wlr_output_init_render 2023-11-30 22:38:52 -06:00
Leonardo Hernández Hernández 00e867d536 use detached output state in createmon()
see previous commit for motivation
2023-11-30 22:38:39 -06:00
Leonardo Hernández Hernández 2e29189b92 use a detached output state in outputmgrapplyortest()
wlr_output.pending might be removed in wlroots 0.18
2023-11-30 22:38:11 -06:00
Leonardo Hernández Hernández 43f31b8f1b improve the bug report template
Fixes: https://codeberg.org/dwl/dwl/issues/498
2023-11-28 23:03:35 -06:00
Leonardo Hernández Hernández ff39cac355 convert issue templates to yaml
also move the templates to .gitea to reflect the migration to Codeberg
2023-11-28 21:28:51 -06:00
Leonardo Hernández Hernández 2e4fdc1664 use l instead of layersurface
`layer_surface` instead of `wlr_layer_surface`
and `scene_layer` whenever a wlr_scene_tree is related to layer surfaces
2023-11-25 19:18:19 -06:00
Leonardo Hernández Hernández b100b446b8 return early if a layersurface didn't commit something 2023-11-25 19:17:32 -06:00
Leonardo Hernández Hernández 9cb1ece6cc do not check if a layer surface has monitor on commit
We do not allow creating them w/o monitor and they are destroyed when
destroying their monitor
2023-11-25 19:17:32 -06:00
Leonardo Hernández Hernández 01a237bd5c send wl_surface.enter before initial commit
It's not necessary but it'll help clients to render a perfect first frame
2023-11-25 19:17:32 -06:00
Leonardo Hernández Hernández a5e068b20a destroy the layer-suface's scene tree for popups 2023-11-25 19:16:33 -06:00
Leonardo Hernández Hernández 39f4ee564b use wlr_box_equal() instead of memcmp 2023-11-25 19:08:56 -06:00
Leonardo Hernández Hernández a353eee2ca simplify settings popups scene tree parent 2023-11-25 19:06:17 -06:00
Leonardo Hernández Hernández 66ec028b00 simplify check for wlr_layer_surface.output 2023-11-25 19:05:27 -06:00
Leonardo Hernández Hernández 1f10e69b4c use sizeof(*pointer) instead of sizeof(struct) 2023-11-25 19:04:57 -06:00
Leonardo Hernández Hernández 922e117fc5 add new 'unreleased' section 2023-11-25 19:04:08 -06:00
Leonardo Hernández Hernández 2783e82bf8 make sure to unlink Monitor.request_state listener 2023-11-25 18:53:18 -06:00
Leonardo Hernández Hernández d08e6a3a7e include CHANGELOG.md in the tarball
Fixes: 24576f1fdf
2023-11-25 01:22:48 -06:00
Leonardo Hernández Hernández f579dd8668 bump version to 0.5 2023-11-25 00:28:11 -06:00
Leonardo Hernández Hernández 24576f1fdf add CHANGELOG.md 2023-11-25 00:21:53 -06:00
Leonardo Hernández Hernández 7ac76219df Merge branch 'wlroots-next' 2023-11-25 00:04:19 -06:00
Leonardo Hernández Hernández 6838f909bd try to apply gamma LUT in updatemons
this in the case the output was re-enabled
2023-11-21 20:41:36 -06:00
Leonardo Hernández Hernández d2dd2f4986 ignore wl_surface.commit for xwayland clients
This is no longer needed
2023-11-21 20:16:26 -06:00
Leonardo Hernández Hernández a0e79d8145 Do not send repeated xdg_toplevel.configure_bounds
Fixes: 32e66f4582
2023-11-21 20:15:46 -06:00
Leonardo Hernández Hernández 32e66f4582 resize clients on commit
Fixes: https://github.com/djpohly/dwl/issues/515
This reverts commit 4567979b16.
2023-11-21 20:15:00 -06:00
Leonardo Hernández Hernández 2751a6195d do not try to enable adaptive sync 2023-11-18 11:20:56 -06:00
Leonardo Hernández Hernández fcf324be6c fix the position of the cursor image after turning all the monitors on 2023-11-17 19:03:23 -06:00
Leonardo Hernández Hernández b8e933b9a9 remove unused #include 2023-11-17 11:03:33 -06:00
Leonardo Hernández Hernández 1044a21555 do not check if session is non-NULL
wlr_session_change_vt() is a no-op if session == NULL
2023-11-17 11:03:33 -06:00
Leonardo Hernández Hernández 6bcd5d8d87 do not explicitly destroy some wlroots interfaces
they are destroyed when the wayland display is destroyed
2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández 7611dc91d7 enable debug symbols by default
they does not affect performance and the size's increase is negligible
2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández e95f14541a fix docs
copied from tinywl
2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández bca1b779aa fix destroynotify() docs
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4421
2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández 7bdbab0400 check toplevel resource instead of client's xdg_shell to set bounds 2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández dd25cdb56e use the new wlroots function to get a toplevel from a wlr_surface
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4419
2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández caac2d664d explicitly return -1 in the first check in toplevel_from_wlr_surface 2023-11-17 11:03:31 -06:00
Leonardo Hernández Hernández b1740056d5 do not use #ifdef -> #else -> #endif in client_is_x11
all other funcions use #ifdef -> #endif
2023-11-17 11:03:31 -06:00
Leonardo Hernández Hernández 0067c76cab delete unused functions 2023-11-17 11:03:31 -06:00
Leonardo Hernández Hernández 22d21676b0 style fixes in client_is_float_type 2023-11-17 11:03:31 -06:00
Leonardo Hernández Hernández d6c102d9db correctly check if the scene node is enabled in client_is_rendered_on_mon 2023-11-17 11:03:31 -06:00
Leonardo Hernández Hernández 0e897608a1 do not use magical numbers to check edges
the interface is declared stable, which means we could just use 0 anyway
2023-11-17 11:03:31 -06:00
Leonardo Hernández Hernández 6d0ec595d3 simplify client_get_clip
the clips for xwayland and xdg clients are pretty similar, after all we only
need to adjust x and y for xdg clients
2023-11-17 11:03:31 -06:00
Leonardo Hernández Hernández 4f4c540bb9 prevent a use-after-free at exit 2023-11-17 11:03:30 -06:00
Leonardo Hernández Hernández 8e3f5364d3 do not compute layout box twice 2023-11-17 11:03:30 -06:00
Leonardo Hernández Hernández 2212363225 make sure fullscreen clients have the right size 2023-11-17 11:03:30 -06:00
Leonardo Hernández Hernández 6f8a3f9374 fix screen artifacts when setting gamma
the artifacts were caused because we tried to set the gamma right after
receiving the event, this resulted in two pending page-flips, which
not always play well together.

This also seems to fix a screen freeze when turning on a monitor that has
gamma.

Additionally the current method won't work once [0] is merged

[0]: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4423
2023-11-17 11:01:30 -06:00
Leonardo Hernández Hernández e1f3983bf8 use wlr_scene_subsurface_tree_set_clip
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4131
Closes: https://github.com/djpohly/dwl/issues/411
2023-11-14 19:44:43 -06:00
Leonardo Hernández Hernández 31bf1cbaf6 Revert "respect size hints"
This reverts commit 72e0a560d9.
2023-11-14 19:44:28 -06:00
Leonardo Hernández Hernández d6fabe3a15 add a comment about chvt keybindings
Closes: https://github.com/djpohly/dwl/issues/427
2023-11-01 12:44:16 -06:00
Leonardo Hernández Hernández a4a83e95e6 use newer cursor naming spec
References: https://www.freedesktop.org/wiki/Specifications/cursor-spec/
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4416
2023-11-01 12:28:19 -06:00
Leonardo Hernández Hernández e45ded7eea ignore maximize events for clients using xdg-shell v5 and newer 2023-11-01 12:16:02 -06:00
Leonardo Hernández Hernández e5e74acfce send maximized if tiled isn't supported (XDG shell)
wlroots doesn't do it automatically anymore

References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4409
2023-11-01 12:04:59 -06:00
Leonardo Hernández Hernández 892a4d3ec7 Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-10-13 17:10:25 -06:00
Leonardo Hernández Hernández ab87410023 clarify the dependencies needed by dwl
Note that previous df131cdb78 libX11 headers
were also required for building (but not for runtime)

Also, I want to apologize to the packagers for do not list *all* the required
dependencies before.
2023-10-11 20:08:44 -06:00
Leonardo Hernández Hernández 7085057f6d update README.md
these things were changed in the code but not in the readme
2023-10-11 19:59:58 -06:00
Leonardo Hernández Hernández 8781f4dbf5 Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-10-09 22:37:36 -06:00
Leonardo Hernández Hernández df131cdb78 use <xcb/xcb.h> instead of <X11/Xlib.h> 2023-10-09 22:33:37 -06:00
Leonardo Hernández Hernández 887fde65a3 only set border color for urgent *and* mapped X11 clients
this fixes a segfault when the client emits .set_hints but it's not mapped

Fixes: 72a7d78a1a
2023-10-09 22:32:15 -06:00
Leonardo Hernández Hernández b299e01e44 Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-10-09 11:45:51 -06:00
Leonardo Hernández Hernández 6d9a915fb6 Revert "just add define"
I'm going to make some changes in the config file anyway

This reverts commit e5367753bb.
2023-10-09 11:12:24 -06:00