asolkar/dwl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
739 Commits 1 Branch 7 Tags 2.4 MiB
2260519740
Commit Graph

567 Commits

Author SHA1 Message Date
Stivvo
573535c89c Unlink fullscreen 2020-12-19 18:05:51 +01:00
Stivvo
60a732ceb8 Restore windows after fullscreen 
Store position and size of windows before going fullscreen. This is more
efficient than arrange() and also works with floating windows

All the clients keep their original position because arrange() isn't
used after quitting fullscreen
 2020-12-19 18:05:51 +01:00
Stivvo
de6db97401 No borders on fullscreen windows 
Some code has been borrowed from the smartBorders patch
 2020-12-19 18:05:51 +01:00
Stivvo
dd3920e75d Toggle fullscreen 2020-12-19 18:05:51 +01:00
Stivvo
0f04c76387 Basic fullscreen 2020-12-19 18:05:51 +01:00
Guido Cella
0f48c9552e handle the x11 configure event 
This fixes the window size of old games in Wine.
 2020-12-19 12:34:32 +01:00
Guido Cella
0016a209e4 implement the virtual keyboard protocol 
This is used by wtype.

Also properly cleanup keyboards. Without wl_list_remove(&kb->link) dwl
crashed after using wtype 2-3 times.
 2020-12-19 12:34:32 +01:00
Guido Cella
90cc3b1e2c Allow toggling the layout before selecting a different one 2020-12-19 12:34:32 +01:00
Guido Cella
41cc23e1cf Implement the idle protocol 
It allows clients such as swayidle and chat applications to monitor user
idle time.
 2020-12-19 12:34:32 +01:00
Guido Cella
1024928c15 deactivate focused client when spawning a new one 
Because maprequest immediately calls wl_list_insert(&fstack, &c->flink),
in the following call to setmon(), the selclient() which is passed to
focusclient() as the old client is actually the newly mapped client, and
the real old one is never deactivated. You can see this by, for example,
opening Chromium's devtools, then spawning a terminal. The background of
the focused line in the devtools doesn't change from light blue to grey.

We can't just remove wl_list_insert(&fstack, &c->flink) from maprequest,
because calling wl_list_remove in focusclient() with a client that has
not been added to the list causes a segmentation fault.
Therefore we fix the focusclient call by not passing it the old client
every time, but instead using the wlroots function that gets the focused
surface and deactivate that, like in TinyWL.
This also avoids getting the selected client and passing it to
focusclient() on every call unnecessarily, and will allow removing
shouldfocusclients in a future commit by checking if old is a layer
surface instead.
 2020-12-19 12:34:31 +01:00
Guido Cella
64faad7cb6 implement the wlr-data-transfer protocol 
It makes wl-clipboard work properly in neovim, without having to create
a transparent surface that steals focus and causes flickering. It's also
required for clipman.
 2020-12-19 12:26:31 +01:00
Guido Cella
ee5bd9a643 fix temporarily disabling a single monitor 
The code in this else completely freezes my system when I run the
swayidle command to replicate xset dpms force off. No idea if it works
on multiple monitors, but for now avoid running when there's 1 monitor.

Also remove the comment with the function name in sway.
 2020-12-19 12:26:14 +01:00
Richard Ipsum
67896e9d8b fix undeclared WLR_KEY_PRESSED 2020-11-23 16:58:43 +00:00
Stivvo
d9ab75721a Don't switch to another disabled monitors 
Since wlr_output_enable doesn't have any effect before finishing all the
procedure, a little hack allows to make use of focusmon(), which must
know the latest in about which output is currently disabled

Also improve performance in focusmon() and cleaner code in
outputmgrapplyortest()
 2020-10-31 18:29:33 +01:00
Stivvo
80a685ee51 Fix crash with no monitors left 
When there's no monitors left, prevent the while in cleanupmon() to
become an infinite loop

Also switch to the left monitors instead of the right
 2020-10-31 17:11:16 +01:00
Stivvo
5221a329e2 closemon() has now only 1 parameter 2020-10-31 16:25:46 +01:00
Stivvo
934ce085b6 Don't switch to disabled mons after unplug 2020-10-31 16:25:29 +01:00
Stivvo
38606a1d23 Merge branch 'handleUnplug' into output-management 2020-10-31 16:16:22 +01:00
Stivvo
9f0b16868a Back to closemon() with one parameter 
With the recent changes in output-management, the extra argument in
closemon() would be needed only when unplugging the monitor, so it isn't
worth it anymore. Also now is more efficient.
 2020-10-31 13:19:31 +01:00
Stivvo
9f3f15b467 Disable mon faster 
Since focusmon() now never focuses disabled monitors, there's no need to
focus the disabled monitor first
 2020-10-31 13:00:55 +01:00
Stivvo
25671d7905 Fix crash when disabling focused mon 
m->link.next leads to errors if the monitor to disable doesn't have a
"next" (right) monitor and is currently focused. dirtmon() does more
checks.

In some previous commits m->link.next is told to be left monitor, which
is wrong

Also focusclient() explicitly checks for disabled monitors (this fixes
in case of more than one disabled monitor)
 2020-10-31 12:52:22 +01:00
Stivvo
5622dbdaf3 Fix crash unplugging focused mon 2 
Focus the top client on newmon, which we know for sure that it isn't
going to be unplugged or disabled and actually set that as the focused
monitor to move the focus. This is necessary to prevent crash when
disabling monitors with the output-management patch.
 2020-10-31 11:17:57 +01:00
Stivvo
0a0e61e58d Merge branch 'handleUnplug' into output-management 2020-10-31 11:04:04 +01:00
Stivvo
fab42e7c41 Fix crash unplugging a focused mon 
Focus newmon, which we know for sure that it isn't be unplugged or
disabled
 2020-10-31 11:03:00 +01:00
Stivvo
a4d42ea798 Focus client on a new monitor before closing 2020-10-31 00:01:59 +01:00
Stivvo
62fb4c086e Block access to disabled monitor 
Before this, pressing mod+comma or mod+period (focusmon function) moved
the focus to disabed monitors. Now, all disabled monitors are skipped
 2020-10-30 23:49:01 +01:00
Stivvo
388ab9df2f Move disabled clients to the left 
To the nearest monitor to the left of the disabled one
 2020-10-30 23:34:26 +01:00
Stivvo
806ebffe7d Merge branch 'handleUnplug' into output-management 2020-10-30 23:31:46 +01:00
Stivvo
fbbc1fd656 Merge branch 'handleUnplug' of http://olidata.stivvo01.com:3000/Stivvo01/dwl into handleUnplug 2020-10-30 23:30:00 +01:00
Stivvo
d4178b9d2a Closemon(), newmon as parameter 
This allows to fix output-management: move clients to the monitor on the
left of the disabled one, instead of the leftmost (which might happen to
be the disabled one)

Also using wl_list_foreach() and then brake after the first iteration is
ugly and inefficient
 2020-10-30 23:22:55 +01:00
Stivvo
4deeddceff Actually move clients away from a disabled mon 
When using wlr-randr every monitor's configuration is reevaluated, so it
must check which monitors are actually being disabled. The only way to
correctly do that is to compare the names.
 2020-10-30 22:35:05 +01:00
Stivvo
874a4df389 Merge branch 'handleUnplug' into output-management 2020-10-30 19:56:14 +01:00
Stivvo
618972696d Fix crash when unplugging a focused monitor 
Just focus a "safe" monitor before trying to to anything risky
 2020-10-30 19:52:20 +01:00
Stivvo
7d67b77a96 Cleaner if statement 2020-10-30 16:21:00 +01:00
Stivvo
42aea0b17d Handle monitor enable 2020-10-25 12:37:05 +01:00
Stivvo
4c0d59c1a7 Move clients away from a disabled monitor 
When a monitor is disabled with wlr_randr, all clients on that monitor
aren't lost but they are moved to the leftmost monitor with the same
method that handles monitor hot unplug
 2020-10-25 11:22:58 +01:00
Stivvo
927352865c Merge branch 'handleUnplug' into output-management 2020-10-25 11:08:08 +01:00
Stivvo
ef7043e4d1 closemon() 
Separate oputput movement from cleanupmon
 2020-10-24 23:40:19 +02:00
Stivvo
db95024211 Merge branch 'handleUnplug' into output-management 2020-10-24 22:51:26 +02:00
Stivvo
fcc869ed84 Readme: achieve fullscreen + allow borderpx = 0 2020-10-24 16:51:22 +02:00
Stivvo
7017a0c64d fix compile error mixed declaration 2020-10-18 18:37:55 +02:00
Guido Cella
f21d3796b8 Move sgeom assignment 
There is no need to repeat this. This needs to be reculalculated in my
output-management implementation too, and since I'm already calling
updatemons, this patch avoids having to repeat the assignment again.
 2020-10-17 20:33:53 +02:00
Guido Cella
b30e18fa20 Implement the output management protocol 
It allows clients such as wlr-randr to configure the display.
 2020-10-17 20:11:31 +02:00
will
7ad14a9660 Added support for natural scrolling 2020-10-17 16:18:44 +02:00
will
598516d808 Added basic tap-to-click for touchpad users 2020-10-17 13:52:53 +02:00
Stivvo
c98686cf16 Quit fullscreen on new x11 window 
After the removal of quitfullscreen() dwl wouldn't compile widh xwayland
enabled because createnotifyx11 was still using the old function
 2020-10-14 17:30:10 +02:00
Stivvo
0ad8473a57 Delete quitfullscreen() 
quitfullscreen() was replicating the functionalities of setfullscreen(c,
0)

Reusing setfullscreen() in quitfullscreen() leads to a 3 line function,
which is useless since quitfullscreen() is used once anyway
 2020-10-14 15:46:35 +02:00
Stivvo
a2ed3d45bb Keep windows fullscreen after redraw 
This fixes the bug that happens when changing workspace (or any time
arrange() is called) where there are fullscreen windows, which are still
fullscreen but leave the space for layer surfaces like waybar (which
should be hidden when going fullscreen)

Also as soon one fullscreen window is found hte function returns to
improve efficiency
 2020-10-08 21:04:53 +02:00
Stivvo
172bcfd3ff Set fullscreen simpler 2020-10-08 21:04:28 +02:00
Stivvo
2b286ffeed use m->m (fullscreen on top of layers) 2020-09-16 09:20:09 +02:00
Stivvo
d8f752c9b4 Keep client tags on unplug 
When unplugging a monitor, each client is moved to the same tag number
as before on the new monitor
 2020-09-15 12:28:58 +02:00
Stivvo
bece225934 Handle monitor unplug 
Floating widndows with "x < removed monitor's width" aren't resized
(they used to disappear in negative coordinates).

Actually delete monitors when they are unplugged, recalculate sgeom and
give a new monitor to clients that were on the removed one with setmon()

arrangefloat() funcion has been exploded to save iterations in
cleanupmon().

Also if a monitor that supports auto suspension is turned off, dwl will
count it as unplugged (it will become unreachable and all clients will
be moved to the leftmost monitor). However, if at least one monitor
isn't plugged in, dwl will still crash the same as before.

Unlike sway, when the output configuration is changed and restored,
(unplug + plug the same monitor for example) previous application
positions aren't kept. This is due to the fact that on sway every
workspace is unique among all monitors.
 2020-09-15 12:28:49 +02:00
Stivvo
537ad7e3fd Restore floating win position after mon add 
Compensate the coordinate changes when adding a new monitor.

Every test so far confirms that monitors are always added to the left,
on top of the list, so every floating window's x coordinate has to be
incremented by the width of the new monitor.
 2020-09-12 00:21:58 +02:00
Guido Cella
0bb25a73ec extract function and comment it 2020-09-11 14:52:59 +02:00
Guido Cella
e4d58c39e0 remove braces 2020-09-11 13:15:31 +02:00
Guido Cella
fbd905155a fix multi monitors even more 
When a monitor is created or removed, the geometries of the old ones
must be updated. This is also more efficient than before since we
calculate the monitor geometries only when creating and destroying
monitors. arrangelayers() is needed to recalculate m->w. arrange() is so
clients don't move to the left monitor when plugging or unplugging
monitors (clients keep the same coordinates but the field below them
changes).
 2020-09-11 13:09:18 +02:00
Guido Cella
8d8d24db09 fix typo 2020-09-10 09:09:46 +02:00
Guido Cella
8f0ce672d3 simplify 2020-09-10 06:01:18 +02:00
Guido Cella
143dce094c fix multi monitors further 
Fix layer surfaces without an exculsive area by using the right x and y
for the current monitor (by Stivvo).
 2020-09-09 17:13:30 +02:00
Bonicgamer
4915214e47
Made scalebox the way sway does it 2020-09-08 14:53:34 -04:00
Guido Cella
62250661cf remove unneeded line 
The bug was caused by usable_area's x and y not being set in
arrangelayers. For example if on a 2nd HD monitor, x should be 1920
while the first one ends at 1919. So I don't see why m->m should be
recalculated after creating the monitor.
 2020-09-08 13:36:46 +02:00
Guido Cella
68412d8957 try to fix again 
Calculate x and y of usable_area, not just width and heigth.
 2020-09-08 12:49:05 +02:00
Guido Cella
69847872bb fix multi monitors 
If you don't recalculate the monitor's geometry before arranging,
clients get arranged in the first monitor. I don't understand why this
fixes the bug since tile() uses m->w rather than m->m, nor why it needs
to be recalculated after creating the monitor but sway does it too.

Although not necessary to fix the bug I also made arrangelayer() do like
sway again and recalculate usable_area instead of reusing m->m, since
m->m seems to be incorrect until it gets recalculated shortly after in
arrange(), so I suspect that leaving usable_area = m->m will cause
issues under certain circumstances.

Someone with a multi-monitor setup or better knowledge of Wayland may be
able to figure out the cause of the bug. For now, this makes layer shell
work.
 2020-09-08 10:28:29 +02:00
Guido Cella
79f3bbaf38 remove variable 2020-09-06 19:59:58 +02:00
Stivvo
d8570d5ceb Allow borderpx = 0 2020-09-06 12:20:41 +02:00
Guido Cella
52a4d3a1e5 use size_t for lengths 2020-09-05 18:29:39 +02:00
Guido Cella
9743778d09 rename variable and merge 2 lines 2020-09-05 14:15:03 +02:00
Stivvo
621d4c9173 Toggle fullscreen on all clients 
mod+e allows to toggle fullscreen any client, even those who don't
support it themselves
 2020-09-05 11:22:24 +02:00
Stivvo
d9cf3e064c Handle new windows 
Windows lose fullscreen state when a new window is created in the same
tag
 2020-09-05 11:02:13 +02:00
Stivvo
73d717a924 isfullscreen int 2020-09-05 10:40:52 +02:00
Stivvo
bd222cb75d Same fscreen func for xdg and xwayland 2020-09-05 10:40:52 +02:00
Stivvo
dd2adb38ae Fullscreen xwayland 2020-09-05 10:40:52 +02:00
Stivvo
aeae3dadbb Unlink fullscreen 2020-09-05 10:37:59 +02:00
Guido Cella
6b25e7ef27 simplify 2020-09-05 06:58:54 +02:00
Guido Cella
8ee0200877 use unsigned int for loop indexes 2020-09-04 21:36:43 +02:00
Guido Cella
ae798c694a Don't let overlays lose focus 
if you open a new window while an overlay is mapped, the overlay should
stay focused
 2020-09-04 21:35:48 +02:00
Guido Cella
8de18f9bb4 fix restoring pointer focus 
I don't know why I thought it was working before. Maybe I should go do
something else.
 2020-09-04 21:14:02 +02:00
Guido Cella
71572521e9 improve code style 2020-09-04 18:45:30 +02:00
Guido Cella
9308a90d11 remove comment 
I don't know why it wasn't working before but now it does ¯\(ツ)/¯
(it wasn't caused by the just removed code either)
 2020-09-04 18:04:20 +02:00
Guido Cella
8e81c90f31 remove mysterious code 
Why would a surface that's not keyboard interactive get focused? Let's
remove this for now and see if issues arise.
 2020-09-04 17:38:37 +02:00
Guido Cella
2d84c74657 focus the previous client in the similar code too 2020-09-04 17:38:04 +02:00
Guido Cella
068352e888 refocus old client 
When a layer surface is destroyed focus should be returned to the last
client. Luckily if there are multiple overlays the previous overlay
still gets focused.
 2020-09-04 17:21:48 +02:00
Stivvo
43bd806291 Restore windows after fullscreen 
Store position and size of windows before going fullscreen. This is more
efficient than arrange() and also works with floating windows

All the clients keep their original position because arrange() isn't
used after quitting fullscreen
 2020-09-04 17:11:26 +02:00
Stivvo
4b1ab7804b No borders on fullscreen windows 
Some code has been borrowed from the smartBorders patch
 2020-09-04 17:09:42 +02:00
Guido Cella
4341deae8f fix alhpabetical order 2020-09-04 17:01:34 +02:00
Guido Cella
5dc9460044 simplify focus leave condition 2020-09-04 16:42:14 +02:00
Guido Cella
35b93669f1 reuse motionnotify() 2020-09-04 15:35:04 +02:00
Stivvo
06982a56b5 Toggle fullscreen 2020-09-04 14:04:19 +02:00
Stivvo
60f0b667b1 Basic fullscreen 2020-09-04 12:44:09 +02:00
Guido Cella
d98ca07a64 enable pointer on layer surfaces 2020-09-04 07:42:51 +02:00
Guido Cella
b26ede4727 more TODOs 2020-09-03 18:59:27 +02:00
Guido Cella
4017a27b67 fix focus leave condition 
needs refactoring and testing
 2020-09-03 18:58:27 +02:00
Guido Cella
b4d9a8662f send pressed keys to topmost layer surface 2020-09-03 18:34:41 +02:00
Guido Cella
5d4eadeb8e remove blank line 2020-08-29 08:42:17 +02:00
Guido Cella
3203d1bafd don't handle failed calloc 
be consistent with the rest of the code
 2020-08-29 08:41:51 +02:00
Guido Cella
ddd3c2ad7e order variables more how like they are initialized 2020-08-29 07:42:47 +02:00
Guido Cella
2c08d0b421 Reuse render() and struct timespec *now 2020-08-28 09:00:03 +02:00
Guido Cella
03c020f058 reuse m->m 2020-08-27 06:45:26 +02:00
Guido Cella
1473d03293 remove comment 
wlr_output_layout_get_box internally calls
wlr_output_effective_resolution
 2020-08-27 06:04:57 +02:00
Guido Cella
c9f92bdd0e set a monitor geometry only when creating it 
Lets layers with an exclusive area shrink the usable area
 2020-08-27 05:22:27 +02:00
Guido Cella
b8a6d3e86a render in the same order as sway 2020-08-27 05:03:01 +02:00
Guido Cella
e13d193346 correct variable name 2020-08-26 19:52:03 +02:00
Guido Cella
ce7bc8125d rename functions too 2020-08-26 19:51:08 +02:00
Guido Cella
e69c3d7336 remove extra space 2020-08-26 19:16:13 +02:00
Guido Cella
b35182f519 render layer surfaces 2020-08-26 19:04:30 +02:00
Guido Cella
1e2dde6674 improve naming 
rename Layer to LayerSurface; layer should refer to overlay, top, bottom
or background
LayerSurface variables are always called layersurface
wlr_layer_surface_v1 variables are always called wlr_layer_surface
 2020-08-26 17:33:17 +02:00
Guido Cella
05df9201b3 layer shell initial attempt 2020-08-24 07:04:34 +02:00
Devin J. Pohly
44ef698d6e set up interfaces in same order as sway 
This makes it easier to compare WAYLAND_DEBUG logs when troubleshooting.
 2020-08-23 10:01:39 -05:00
Guido Cella
1c9a0d8822 enable gamma control 2020-08-22 18:09:38 +02:00
Devin J. Pohly
620da43933 cleanup function to match dwm 2020-08-19 00:32:57 -05:00
Devin J. Pohly
8eb6fe8e9e fix usage to match 2020-08-19 00:32:32 -05:00
Devin J. Pohly
3b1992ca91 we're not really using the log 2020-08-19 00:30:00 -05:00
Devin J. Pohly
f79746c578 this is technically barf too I guess? 2020-08-19 00:24:57 -05:00
Devin J. Pohly
f13227ebae only call updatewindowtype for x11 windows 2020-08-19 00:23:54 -05:00
Devin J. Pohly
ad9b3bc65d handle NULL return from backend_autocreate 
Fixes #44.
 2020-08-18 19:43:42 -05:00
Devin J. Pohly
83f60e89b0 add macro for fatal errors 
dwm lets the OS do cleanup if the program errors out
 2020-08-18 19:39:34 -05:00
Devin J. Pohly
d615d3836c Use SIGCHLD handler from dwm 
Fixes #46.
 2020-08-18 18:22:44 -05:00
Devin J. Pohly
c0b05eddb8 make this marginally less ugly 2020-08-16 11:36:38 -05:00
Devin J. Pohly
41c3f91b03 wlr_session_change_vt is NULL safe 2020-08-16 11:32:45 -05:00
Devin J. Pohly
c970d97f85 _net_wm not needed outside xwayland 2020-08-16 01:14:54 -05:00
Devin J. Pohly
108ade0bbc
Merge pull request #37 from alex-courtis/31-independents-mouse-focus 
31 independents mouse focus
 2020-08-16 00:57:18 -05:00
Guido Cella
c0608aa017 Declare commitnotify 2020-08-15 16:47:22 +02:00
Alexander Courtis
4788baee8d Merge branch 'master' into 31-independents-mouse-focus 2020-08-11 11:42:02 +10:00
Alexander Courtis
2616812a7a #24 ensure that xwayland cursor defaults to left_ptr 2020-08-11 11:29:32 +10:00
Alexander Courtis
e7318f7623 Merge branch 'master' into 24-xwayland-cursor 2020-08-11 11:23:58 +10:00
Devin J. Pohly
e3e9504fcd make XWayland support optional 2020-08-10 12:50:56 -05:00
Alexander Courtis
5b464edf91 #31 independents retain focus while mouse is over them 2020-08-09 11:56:34 +10:00
Alexander Courtis
9551568252 #31 independents retain focus while mouse is over them 2020-08-09 11:34:19 +10:00
Alexander Courtis
9d138ac95a #31 independents retain focus while mouse is over them 2020-08-06 15:41:04 +10:00
Alexander Courtis
c08ea88c1f #31 independents retain focus while mouse is over them 2020-08-06 15:32:55 +10:00
Alexander Courtis
f593820ede #24 ensure that xwayland cursor defaults to left_ptr 2020-08-04 11:53:23 +10:00
Devin J. Pohly
5a2d87fa6c add monocle layout 2020-08-03 12:44:47 -05:00
Devin J. Pohly
27bbf9c14f condense getatom and add note about error return 2020-08-03 12:22:02 -05:00
Devin J. Pohly
c12261d3a9 Merge branch 'master' of github:djpohly/dwl into master 2020-08-03 12:14:36 -05:00
Devin J. Pohly
8c95418334
Merge pull request #25 from geistesk/error-maybe-uninitialized 
getatom: fix potential uninitialized atom variable
 2020-08-03 12:14:27 -05:00
Devin J. Pohly
d89cf6b720 add some more hands-off protocols 2020-08-03 11:20:12 -05:00
Devin J. Pohly
0ac2f6616a fix an editing mistake 2020-08-02 18:49:23 -05:00
Devin J. Pohly
59cd8dec94 focusclient checks whether oldsel == sel 
No need to do it outside the call.
 2020-08-02 18:46:34 -05:00
Devin J. Pohly
ef7a37649c refactor focusclient 2020-08-02 18:43:29 -05:00
Devin J. Pohly
7856cdc1bf abc 2020-08-02 18:40:33 -05:00
Devin J. Pohly
da5deab083 convert lastfocused() to focustop(m) 2020-08-02 18:39:48 -05:00
Devin J. Pohly
8a584d406d pass previous focus to focusclient 2020-08-02 18:33:42 -05:00
Devin J. Pohly
e7e01e06f6 remove surface from focusclient function 
Honestly not sure why a specific surface is focused rather than the
client figuring that out.  Seems to work in a quick test, but we can
remember this commit if something breaks for, I dunno, mouse people.
 2020-08-02 18:26:58 -05:00
Devin J. Pohly
17e525cc6c C99 doesn't support anonymous unions 
I'm cool with ->surface.xdg instead of ->xdg_surface though.
 2020-08-02 09:16:07 -05:00
Devin J. Pohly
62339e7ab0 make setmon a bit more straightforward 2020-08-02 00:35:26 -05:00
Devin J. Pohly
e41ed53384 remove unneeded variable 2020-08-01 09:45:33 -05:00
Devin J. Pohly
2dbe5c6063 simplify pointerfocus 
Similar to focusclient
 2020-07-31 14:00:00 -05:00
Devin J. Pohly
90d80c0de9 simplify focusclient 
This arranges the function into some logical tasks: deactivate the old
client, update wlroots' keyboard focus, update our data structures, and
activate the new client.  The last two only need to be done when
focusing something new, so an early return saves some horizontal space.
 2020-07-31 13:53:33 -05:00
Devin J. Pohly
0a59f47c18 remove now-unused variables in focusclient 2020-07-31 13:24:10 -05:00
Devin J. Pohly
50aa44c59b add tag bitset check from dwm 2020-07-31 09:57:59 -05:00
Alvar Penning
744f20790c getatom: fix potential uninitialized atom variable 
The getatom function returns the atom variable, which is only
initialized in case of a success. This results in a maybe-uninitialized
warning/error. After this commit, now a zero value is returned in case
of error.
 2020-07-31 12:53:46 +02:00
Devin J. Pohly
4e57dbd922 attach_render and commit are all that's needed 
attach_render tells the output that a "new" buffer has been prepared
(even if we haven't changed it).  We need to call that and then commit
it to keep the render loop going.

Software cursors will freeze momentarily during layout updates, but I
suspect that this is not as easily fixed as it sounds.  You can force
software cursors by running:

    WLR_NO_HARDWARE_CURSORS=1 ./dwl
 2020-07-30 22:52:53 -05:00
Devin J. Pohly
21437b62af style fixes 2020-07-30 21:55:49 -05:00
Alexander Courtis
d6a18d69c0 do not render frames when any surface has uncommitted resizes 2020-07-30 21:52:09 -05:00
Alexander Courtis
7499044a2b tidy activate notify resource 2020-07-29 15:05:24 +10:00
Devin J. Pohly
d5fdd999ac make border color selection concise 2020-07-26 19:27:49 -04:00
Michael Cardell Widerkrantz
2fb3701c6e Add support to change focused window's border color 2020-07-26 23:10:42 +02:00
Devin J. Pohly
e2887f2cfd remove client.isx11 in favor of client.type 2020-07-25 12:03:08 -04:00
Devin J. Pohly
0e21cce803 ok, treat it like an enum 2020-07-25 11:57:47 -04:00
Devin J. Pohly
3e29ef1c7e do managed/unmanaged check in map and unmap 2020-07-25 11:55:18 -04:00
Devin J. Pohly
f2d025d4e9 do managed check in activatex11 2020-07-25 11:48:47 -04:00
Devin J. Pohly
e5e170e420 add client.type field 
Current options are XDGShell, X11Managed, and X11Unmanaged.
 2020-07-25 11:46:12 -04:00
Devin J. Pohly
39f3b87f3a rename activate to activatex11 for consistency 2020-07-25 11:46:12 -04:00
Devin J. Pohly
8b7cc8ada6 clarify createnotifyx11 function 2020-07-25 11:29:36 -04:00
Alexander Courtis
c4cf78aadb xwayland: unmanaged (dropdown menu) support 2020-07-25 11:29:02 -04:00
Devin J. Pohly
4bc7f2d8e4 remove n counter from zoom(), add comments 2020-07-24 17:35:19 -04:00
Guido Cella
7b608da8c5 Add zoom 2020-07-24 17:30:45 +02:00
Devin J. Pohly
53798dfbff fix WLR_SURFACE macro 2020-07-23 19:32:10 -04:00
Devin J. Pohly
5d66ea8a99 don't double-add new monitor to mons 
this was a copy/paste error
 2020-07-23 18:14:33 -04:00
Devin J. Pohly
d42d8bda42 add cleanup listener for keyboards 2020-07-23 18:13:42 -04:00
Devin J. Pohly
89e9a4be33 add monitor destroy listener 2020-07-23 18:03:13 -04:00
Devin J. Pohly
5ca1e22fef reorder teardowns 2020-07-23 17:36:20 -04:00
Devin J. Pohly
8b13e42d3f fix more unfreed memory 2020-07-23 17:34:50 -04:00
Devin J. Pohly
bc65c1a570 output_layout_manager not auto-destroyed 2020-07-23 17:20:23 -04:00
Devin J. Pohly
91000b5e76 xcursor_manager is not automatically destroyed 2020-07-23 17:16:02 -04:00
Guido Cella
ea73221b45 Add killclient 2020-07-23 20:30:25 +02:00
Devin J. Pohly
4a4a261111 let xdg be the plain "createnotify" 
use x11 suffix for other function to match isx11, also shorter
 2020-07-22 20:54:39 -04:00
Devin J. Pohly
ce2c9e6660 xwayland is the exceptional case, let xdg be 0 2020-07-21 23:25:16 -04:00
Devin J. Pohly
a10357fae0 condense appid/title logic 2020-07-21 18:47:30 -04:00
Devin J. Pohly
a21c9378ee fix segfault on xwayland "appid" 2020-07-21 18:43:26 -04:00
Alexander Courtis
57fef50310
xwayland: add server and basic window functionality (#10) 
* xwayland: add server and basic window functionality

* xwayland: add server and basic window functionality

* xwayland: add server and basic window functionality

* xwayland: add server and basic window functionality
 2020-07-21 18:35:46 -04:00
Lauri Gustafsson
91b18d4d4d
Add repeat delay and repeat rate to config.h (#13) 2020-07-02 15:41:12 -05:00
Devin J. Pohly
728e0e5d71 clear correct focus on keyboard leave 2020-06-15 09:22:43 -05:00
Shugyousha
63f09d1f23
Don't pass NULL surfaces to wlr focus functions (#8) 
Turns out that this will hit asserts that will abort dwl.
 2020-06-14 04:05:21 -05:00
Devin J. Pohly
14063d58bb Handle missing XDG_RUNTIME_DIR explicitly 
Also update the documentation to indicate that this is a Wayland thing
and not dwl-specific.
 2020-06-07 11:43:48 -05:00
Devin J. Pohly
f19d00b94a move perrors earlier 
Should come right after the erroring call so nothing else has a chance
to overwrite errno
 2020-06-07 11:42:43 -05:00
Martin Tournoij
da5b4d965d
Add startup errors, mention XDG_RUNTIME_DIR in README 
It was just exiting with code 1 for me. The problem turned out to be
that you *need* to set XDG_RUNTIME_DIR or it won't work (I think e.g.
systemd does that for you, but on Void it's not set by default), so
mention that in the README.
 2020-06-07 14:51:02 +08:00
Devin J. Pohly
8c0afa7c73 send xdg_decoration configure right after create 
Thanks to @cedws for pointing this out!
 2020-06-07 01:12:02 -05:00
Devin J. Pohly
2598100d53 Implement xdg-decoration protocol 
Applications like alacritty which use this newer protocol will no longer
attempt to draw their own decoration.
 2020-06-04 23:37:31 -05:00
Devin J. Pohly
5991cec0ff Write something more intuitive for focusclient() 2020-06-03 19:45:40 -05:00
Devin J. Pohly
78187f5e65 document -qvd options 2020-06-03 15:05:12 -05:00
Devin J. Pohly
67299a18a5 make sure freed listeners are removed from list 2020-05-10 01:04:31 -05:00
Devin J. Pohly
c6833cf93e add output manager protocol 2020-05-09 23:01:30 -05:00
Devin J. Pohly
59d16e491a add screencopy support 
While we're taking low-hanging fruit here...
 2020-05-09 22:48:19 -05:00
Devin J. Pohly
0bd4eb8ff3 add primary selection support too! 2020-05-09 22:45:22 -05:00
Devin J. Pohly
0b0dd6b63c handle request set selection 
Ported from wlroots commit fa5d709
 2020-05-09 22:30:20 -05:00
Devin J. Pohly
94bb68afe1 use wlr_xdg_surface.set_tiled correctly 
Closes #2.  I'm guessing from sway that the idea of setting maximized
state so that windows cooperate is superseded by using set_tiled.
 2020-05-09 14:50:31 -05:00
Devin J. Pohly
cad233b605 initialize global listeners statically 2020-05-09 10:10:02 -05:00
Devin J. Pohly
5817c917b6 abc 2020-05-03 13:18:53 -05:00
Devin J. Pohly
323092d3ce remove vestigial listeners 2020-05-03 13:18:10 -05:00
Devin J. Pohly
7212da059c no need for a line split here 2020-05-03 12:41:15 -05:00
Devin J. Pohly
1a30d9908d no conditional needed for output modes 
If the output backend doesn't support modes, get_preferred_mode will
return NULL, and set_mode will accept NULL.
 2020-05-03 11:45:47 -05:00
Devin J. Pohly
b19afa10f3 use strstr for monrules 2020-05-03 11:39:48 -05:00
Devin J. Pohly
7afe152c47 add reminder comment 2020-05-03 11:38:34 -05:00
Devin J. Pohly
1b87831e00 inline xytosurface 2020-05-03 11:37:44 -05:00
Devin J. Pohly
f7d2524435 split xytoclient and xytosurface 2020-05-03 11:31:55 -05:00
Devin J. Pohly
835a46ef30 style 2020-05-03 11:23:51 -05:00
Devin J. Pohly
1d0350fa3d refocus -> lastfocused 2020-05-03 11:23:39 -05:00
Devin J. Pohly
cf65fd8c9a raise client on refocus 
Might revisit this later, but this currently seems like the right
strategy.
 2020-05-03 00:55:00 -05:00
Devin J. Pohly
86d8cb1804 add client rules 2020-05-03 00:49:02 -05:00
Devin J. Pohly
5de1cfbebf allow setmon to specify alternate tags 2020-05-03 00:44:16 -05:00
Devin J. Pohly
b10ef0e80a loop over array pointers directly 2020-05-03 00:41:37 -05:00
Devin J. Pohly
2e7b5310b4 includes: abc 2020-05-02 15:24:18 -05:00
Devin J. Pohly
3096d4eec1 set default cursor over window borders 2020-05-02 15:22:07 -05:00
Devin J. Pohly
ecdd012f6b sacrifice 24 lines to suckless style :) 2020-05-02 15:21:36 -05:00
Devin J. Pohly
20ed6cb3d5 allow passing NULLs to xytoclient 
For sx/sy, these are handled by the underlying call to
wlr_surface_surface_at.
 2020-05-02 14:43:28 -05:00
Devin J. Pohly
8c80f74513 remove outdated/fixed comment 2020-05-02 14:33:32 -05:00
Devin J. Pohly
187d25e838 style: int instead of bool 2020-05-02 14:32:23 -05:00
Devin J. Pohly
d0df4d0d72 correct standard include for signal.h 
Fixes #1.  Thanks @sdsddsd1!
 2020-05-02 10:42:51 -05:00
Devin J. Pohly
87f8e6687b include border in xytoclient 
If there isn't an actual surface under the cursor, *surface will be set
to NULL, which is safe now that focus functions handle a NULL surface
safely.
 2020-04-30 12:32:57 -05:00
Devin J. Pohly
2c134faa40 allow NULL surface with client in focus functions 2020-04-30 11:37:04 -05:00
Devin J. Pohly
33b0236858 make move-grab coords client-relative 2020-04-30 11:33:32 -05:00
Devin J. Pohly
3973ea5bfe unify movemouse/resizemouse 2020-04-30 10:25:37 -05:00
Devin J. Pohly
53e71957f8 fix a long line 2020-04-26 22:19:48 -05:00
Devin J. Pohly
40d0d0f829 wait to get window geometry until map time 2020-04-26 22:18:39 -05:00
Devin J. Pohly
34d5045d84 use wlr_box for client geometry 2020-04-26 22:12:08 -05:00
Devin J. Pohly
a25ad1c327 call arrange only where needed 
A few of these could probably even be more specific, but this is where
dwm's calls are.
 2020-04-26 22:02:47 -05:00
Devin J. Pohly
499a43db74 funnel isfloating changes through setfloating() 2020-04-26 21:55:49 -05:00
Devin J. Pohly
ce5d116efd move comment where it's more relevant 2020-04-26 21:42:45 -05:00
Devin J. Pohly
dd50a3ee04 mouse move now changes window monitor 2020-04-26 21:35:21 -05:00
Devin J. Pohly
19e712625f options to select log level 2020-04-26 21:32:44 -05:00
Devin J. Pohly
b2960e53de rename keyboardfocus() to focusclient() 2020-04-26 20:17:47 -05:00
Devin J. Pohly
7094bcc5e3 integrate raiseclient into keyboardfocus 2020-04-26 20:16:47 -05:00
Devin J. Pohly
6d5726e426 don't pass compositor button events to client 2020-04-26 20:12:54 -05:00
Devin J. Pohly
b025b7bdbd render windows across monitors 2020-04-26 20:00:06 -05:00
Devin J. Pohly
aa7020b344 abc 2020-04-26 19:48:28 -05:00
Devin J. Pohly
8f02449cb4 funnel all monitor-moving through setmon() 2020-04-26 19:47:38 -05:00
Devin J. Pohly
847cd4c488 I'm good with changing the loglevel here... 2020-04-26 17:43:03 -05:00
Devin J. Pohly
309f6c96cf hang some stuff on ->data 
Sure it'll be useful at some point.  Like here.
 2020-04-26 17:42:10 -05:00
Devin J. Pohly
ab51576556 linesaver in pointerfocus 2020-04-26 14:47:23 -05:00
Devin J. Pohly
cd6683e6a1 fix refocus on sendmon 2020-04-26 14:11:44 -05:00
Devin J. Pohly
88f0ea343b make sure windows always overlap with their monitor 2020-04-26 14:08:47 -05:00
Devin J. Pohly
48a8adb70a track window width/height 2020-04-26 13:18:20 -05:00
Devin J. Pohly
5dd8a5f22f use wlr_box for monitor regions 2020-04-26 12:41:33 -05:00
Devin J. Pohly
2fb9f53483 save lines in keyboardfocus 2020-04-26 12:01:08 -05:00
Devin J. Pohly
d34bf87dba don't unfocus when mouse leaves a window 2020-04-26 12:01:00 -05:00
Devin J. Pohly
6cad698517 fix multi-dpi scaling 2020-04-25 01:18:28 -05:00
Devin J. Pohly
c00da5eeb0 clarify keyboardfocus vs pointerfocus 2020-04-24 00:12:58 -05:00
Devin J. Pohly
60f2c0b7de draw window borders 
Works with scaled/rotated displays too!
 2020-04-23 23:55:29 -05:00
Devin J. Pohly
6254bcd033 factor out scalebox() 
May switch to the version from sway if that seems like a good idea at
some point.
 2020-04-23 23:52:27 -05:00
Devin J. Pohly
6e02b421cd note about cursor init 2020-04-23 23:47:52 -05:00
Devin J. Pohly
ee2b3af1ca configure monitor rotation/reflection 2020-04-23 23:44:54 -05:00
Devin J. Pohly
2cb526bbd9 add chvt function 
It truly isn't just a window manager anymore :-|
 2020-04-23 23:44:54 -05:00
Devin J. Pohly
1870187d62 make space for window borders 2020-04-23 23:35:54 -05:00
Devin J. Pohly
fb6b16aeee change cursor during move and resize 2020-04-23 23:35:54 -05:00
Devin J. Pohly
2f21445761 style in buttonpress 2020-04-23 23:35:54 -05:00
Devin J. Pohly
288f6397fa simplify move/resizemouse functions 2020-04-23 23:35:54 -05:00
Devin J. Pohly
073c35ae2f funnel all resizing through resize() 2020-04-23 23:35:54 -05:00
Devin J. Pohly
60c887f3c0 use exit code macros everywhere 2020-04-23 23:35:54 -05:00
Devin J. Pohly
84da7b4470 some comments and reminders 2020-04-23 23:35:54 -05:00
Devin J. Pohly
275badc707 factor out renderclients 
This will help once we get to implementing layer-shell
 2020-04-23 23:16:56 -05:00
Devin J. Pohly
15ed82571b don't autoraise 
Still raise in buttonpress and focusstack of course.  Focus models
honestly wouldn't be too hard to make into a config.h option.
 2020-04-23 22:15:30 -05:00
Devin J. Pohly
e6bcf95e2e use the focus stack to determine stacking order 
Suddenly we have autoraise!
 2020-04-23 22:11:52 -05:00
Devin J. Pohly
a5a7445dee adopt a bit more dwm-like terseness 2020-04-23 22:11:52 -05:00
Devin J. Pohly
66bf55930f change focus(NULL, NULL) to mean unfocus 
"Focus the most recently focused window on selmon" is now refocus()
 2020-04-23 22:11:52 -05:00
Devin J. Pohly
0d8f51e0a3 implement focusmon and tagmon 2020-04-23 22:11:52 -05:00
Devin J. Pohly
a87adfd77c focus follows mouse 2020-04-23 22:11:52 -05:00
Devin J. Pohly
4eabe48fed add incnmaster and setmfact commands 2020-04-23 22:11:52 -05:00
Devin J. Pohly
66054700cb add toggletag and toggleview 2020-04-23 22:11:52 -05:00
Devin J. Pohly
35557ab042 don't detect non-visible clients under cursor 2020-04-23 22:11:52 -05:00
Devin J. Pohly
387dff81b3 add tag and view functions 2020-04-23 22:11:52 -05:00
Devin J. Pohly
fda58764ab refocus if focused client is unmapped 
focus(NULL, NULL) works like dwm's focus(NULL): focus the most recent
visible client on selmon, or clear the existing focus if there are none.
 2020-04-23 22:11:48 -05:00
Devin J. Pohly
c03081d85d implement floating windows 2020-04-23 19:48:00 -05:00
Devin J. Pohly
e447cd0215 load scaled cursor theme with each output 2020-04-23 19:12:58 -05:00
Devin J. Pohly
623867a367 turn focusnext into dwm's focusstack 2020-04-23 00:47:15 -05:00
Devin J. Pohly
59b09576b9 restrict focusnext to the same monitor 2020-04-23 00:38:09 -05:00
Devin J. Pohly
a634b3f2e4 style 2020-04-23 00:33:58 -05:00
Devin J. Pohly
9b2eec24c2 add selclient() helper 
This may get inlined later, but it's nice for now.  The focused client
if any should always be both at the top of fstack and visible on selmon.
 2020-04-23 00:32:28 -05:00
Devin J. Pohly
3593da0e15 continue to focus monitor under mouse cursor 2020-04-22 22:56:24 -05:00
Devin J. Pohly
240be1af19 focus monitor under mouse cursor initially 2020-04-22 22:55:57 -05:00
Devin J. Pohly
f88a98327e grabbed_client was too long a name 2020-04-22 22:38:14 -05:00
Devin J. Pohly
1595256341 inline moveresize 
There were only two lines left in common
 2020-04-22 22:34:11 -05:00
Devin J. Pohly
0a43197203 grabsx/y are only used by move now 2020-04-22 12:00:10 -05:00
Devin J. Pohly
749880cedd calculate resize based just on cursor/window 
This eliminates the need for grab_height and grab_width.
 2020-04-22 11:59:52 -05:00
Devin J. Pohly
def3572117 add setlayout function 2020-04-22 11:20:23 -05:00
Devin J. Pohly
fdbe9ee29a Don't change tiling order in focusnext() 
Use the focus stack instead to determine which client is focused
 2020-04-22 11:05:41 -05:00
Devin J. Pohly
10bf0ff566 add separate list of clients for focus order 
Previously, clicking a client to focus it would change where it was in
the tiled layout as well.
 2020-04-22 10:42:40 -05:00
Devin J. Pohly
3707e0115a layouts: tile and floating 
Behavior's still a little wonky but positioning is there.
 2020-04-22 08:25:43 -05:00
Devin J. Pohly
6f9f1b9e05 "root" color was easy to make configurable 2020-04-21 21:58:13 -05:00
Devin J. Pohly
ffc19434ee fix rendering on scaled monitors 
I have no idea why this takes the raw unscaled resolution, and then we
have to multiply by the scale *again* in render(), but that's life.
 2020-04-21 21:56:01 -05:00
Devin J. Pohly
1907ee3879 introduce rules for monitor configuration 
(with dwm, this would already have been done by the X server)
 2020-04-21 21:53:34 -05:00
Devin J. Pohly
97f29ec67f no need to manage unmapped clients 
is there?
 2020-04-21 20:55:06 -05:00
Devin J. Pohly
c37aa00aec consistent naming for coordinate variables 
x and y are reserved (inasmuch as it's dwl's choice) for coordinates
relative to the layout.  ox and oy are used for output-relative
coordinates.  sx and sy are surface-relative.  dx and dy are deltas.

figuring this out the first time was kind of a Thing... just don't pay
attention to what happens in render and you should be fine.
 2020-04-21 19:42:21 -05:00
Devin J. Pohly
cdeff2475d inline xytosurface in xytoclient 
It was a simpler function than it looked
 2020-04-21 19:17:44 -05:00
Devin J. Pohly
0e9bceb8b6 comment updates 2020-04-21 19:09:36 -05:00
Devin J. Pohly
552deb7026 split out setup() and run() 2020-04-21 18:57:04 -05:00
Devin J. Pohly
23924022c9 cherry-pick 25d0d1b from upstream 2020-04-21 17:45:44 -05:00
Devin J. Pohly
26714f172a inline handlemove/handleresize 2020-04-21 17:45:44 -05:00
Devin J. Pohly
599bec5583 render_data only needs coordinates, not Client 2020-04-21 17:45:44 -05:00
Devin J. Pohly
7056fbe101 abc 2020-04-21 17:45:44 -05:00