asolkar/dwl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
1,265 Commits 1 Branch 7 Tags 2.5 MiB
43016bdad8
Commit Graph

976 Commits

Author SHA1 Message Date
Devin J. Pohly
68a17f962e Don't bother with ignoring SIGCHLD 
It added complexity, especially with the differences in behavior between
handled and ignored signals across an exec().
 2023-06-16 00:24:17 -06:00
Devin J. Pohly
9c592da01f Reset ignored signal handler in spawn() as well 2023-06-16 00:24:17 -06:00
Devin J. Pohly
df11b7a786 fix startup_cmd SIGCHLD handler 
Ignored handlers are not reset by exec() calls
 2023-06-16 00:24:17 -06:00
Leonardo Hernández Hernández
1e1811f953
drop KDE idle support 
use ext-idle-notify-v1 instead
 2023-06-15 12:32:31 -06:00
Leonardo Hernández Hernández
dfb6b97159
drop support for wlr-input-inhibitor-unstable-v1 
deprecated in favor of ext-session-lock-v1

References: 4aa366e3dd
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3848
 2023-06-15 12:27:34 -06:00
Leonardo Hernández Hernández
65f68e7643
use wlr_scene_output_build_state() to set gamma 2023-06-15 12:22:43 -06:00
Leonardo Hernández Hernández
96ab92cdb1
use wlr_cursor_set_xcursor() 
This avoids re-upload the cursor image in each motion event

Managing the scale is done by the function itself

References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4170
 2023-06-15 12:12:22 -06:00
Leonardo Hernández Hernández
1eb8a82ac4
Revert "avoid setting duplicate cursor image" 
This reverts commit b5776e5180.

See next commit for details
 2023-06-15 12:02:30 -06:00
Leonardo Hernández Hernández
24a337e6ec
handle gamma-control-v1 set_gamma event 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4046
 2023-06-08 23:35:46 -06:00
A Frederick Christensen
5215712cab Stray whitespace fixes 2023-06-07 17:47:36 -06:00
Leonardo Hernández Hernández
f3d017077a
use the new {a,di}ssociate events to handle xwayland commit listener 2023-06-02 22:08:17 -06:00
Leonardo Hernández Hernández
06bc65549f
chase wlroots map logic unification 
Signed-off-by: Leonardo Hernández Hernández <leohdz172@proton.me>
 2023-06-02 22:03:41 -06:00
Leonardo Hernández Hernández
a8ccbe63f3
Merge branch 'main' into wlroots-next 2023-06-02 22:01:39 -06:00
Leonardo Hernández Hernández
9b9b79b35e
activate lock surface in updatemons 
Fixes an issue when swaylock does not receive input after turn off and then
turn on the outputs
 2023-06-02 21:56:09 -06:00
Leonardo Hernández Hernández
3d98907b98
send frame done even if output commit fails 
Bug: https://github.com/djpohly/dwl/issues/420
Fixes: https://github.com/djpohly/dwl/issues/353
 2023-06-02 21:51:47 -06:00
Nikita Ivanov
f8884ffc2b Set XCURSOR_SIZE 2023-06-01 19:11:33 -06:00
Leonardo Hernández Hernández
72adab621f destroy old client popups when focusing another client 
Closes: https://github.com/djpohly/dwl/issues/408
 2023-05-27 23:29:05 -06:00
Micah Gorrell
0729f18dce Prevent using a wlr_layer_surface after destroying it, due to no available outputs 2023-05-25 21:21:56 -06:00
Leonardo Hernández Hernández
2d1a40caf2
pass version to wlr_compositor_create() 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3696
Signed-off-by: Leonardo Hernández Hernández <leohdz172@proton.me>
 2023-04-14 12:25:05 -06:00
Leonardo Hernández Hernández
733754bb06
Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-04-14 12:24:19 -06:00
Leonardo Hernández Hernández
797e0c74b2
correctly check if a scene node is enabled 
checking only wlr_scene_node.enabled may result in a false positive because it
does not consider if its ancestors are enabled as well.
 2023-04-13 13:12:27 -06:00
Leonardo Hernández Hernández
3c760bcd4a
remove unneeded check of m in arrange() 
arrange must never be called with a NULL argument
 2023-04-13 13:12:27 -06:00
Ben Collerson
da77e34ee5 Use uint32_t for ui Arg 2023-04-09 17:09:35 -06:00
Leonardo Hernández Hernández
20f61a59af
use fixed-size type for client tags 
while the size of `int` in most compilers is 32-bits, the size of int and all
other integer types are implementation defined, so make sure we can use up to
32-bits
 2023-04-08 11:29:18 -06:00
Ben Collerson
9d68554c59
remove tag labels from dwl 
Tag labels are not used in dwl. Only the number of tags is important.
Tag labels should be defined for each tag in whatever status bar is
used.
 2023-04-08 11:27:49 -06:00
Yves Zoundi
bbdf2a913b
display clients count in monocle symbol 
- Replicate missing functionality from dwl to display the client count in monocle mode
  - Add ltsymbol field to Monitor struct
  - Display client count in monocle mode when greater than zero
- Tested with somebar and dwlb
 2023-03-16 00:02:14 -06:00
A Frederick Christensen
6722a89532 Missing apostrophe 2023-03-07 22:17:05 -06:00
Leonardo Hernández Hernández
eaf6dd2cd2
do not call dmabuf_create twice 
it is called automatically by `wlr_renderer_init_wl_display()` but since we
need a pointer to wlr_linux_dmabuf_v1 to integrate it with scene API we need
to recreate that function.

Bug: https://github.com/emersion/xdg-desktop-portal-wlr/issues/216
Fixes: https://github.com/djpohly/dwl/issues/398
 2023-03-07 22:04:32 -06:00
Leonardo Hernández Hernández
d1b36925c9
add support for linux-dmabuf-unstable-v1 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3726
References: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
 2023-02-20 21:24:18 -06:00
godalming123
c69a2bec3f Fix spacing and replace it with tabs 2023-02-18 18:47:44 -06:00
godalming123
737688a6b1 fix spelling 2023-02-18 18:47:44 -06:00
Leonardo Hernández Hernández
fefcdbed4a
Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-02-13 13:46:41 -06:00
pino-desktop
f8373ccf25
Fixed 'unused variable' compiler warning. 2023-02-13 13:43:28 -06:00
Ben Collerson
7f9a212476
Add appid field to printstatus() output 
Adds an appid field to printstatus which can be used to monitor the
currently active application.
 2023-02-13 13:30:27 -06:00
Leonardo Hernández Hernández
ab8334bd8a
implement repeatable keybindings 2023-02-13 13:18:43 -06:00
Leonardo Hernández Hernández
23ede80f74
allow configure x and y of outputs 2023-02-13 13:14:29 -06:00
Leonardo Hernández Hernández
04fdf1a295
add support for wp-fractional-scale-v1 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3511
 2023-02-08 22:25:41 -06:00
Leonardo Hernández Hernández
fbe89a929f
chase wlroots!4000 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4000
 2023-02-05 10:03:09 -06:00
Leonardo Hernández Hernández
f7d6a34cd9
use sigaction(2) for signal handling 
References: http://git.suckless.org/dwm/commit/712d6639ff8e863560328131bbb92b248dc9cde7.html
 2023-01-30 23:26:32 -06:00
Leonardo Hernández Hernández
cf9c5745e5
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-12-30 15:29:12 -06:00
Leonardo Hernández Hernández
dbe44e48c8
return early if selmon is not part of the output layout in dirtomon() 
instead of checking twice
 2022-12-30 14:31:56 -06:00
Leonardo Hernández Hernández
0b2c33248c
simplify check in urgent() 
we only care if it returned a client or not
 2022-12-30 14:29:19 -06:00
Leonardo Hernández Hernández
56114f700f
arrange monitor after updating fullscreen background and lock surfaces 2022-12-30 14:26:53 -06:00
Leonardo Hernández Hernández
71c7e4e1e5
also update locked_bg node position in updatemons() 2022-12-30 14:25:19 -06:00
Leonardo Hernández Hernández
72d29f1654
add blank lines to make updatemons() more readable 2022-12-30 14:21:46 -06:00
Leonardo Hernández Hernández
e523c2b82b
update comment about client_set_size() as no-op 2022-12-30 14:19:47 -06:00
Leonardo Hernández Hernández
6d0e3a5198
check if a client is resizing before checking if it's visible 
It's not like it's noticeable, but theoretically this is faster
 2022-12-30 14:15:21 -06:00
Leonardo Hernández Hernández
5347ed663d
only mark pending resizes as completed checking the configure serial 2022-12-30 14:14:06 -06:00
Leonardo Hernández Hernández
b39d270b9f
Merge branch 'main' into wlroots-next 2022-12-24 18:04:41 -06:00
Leonardo Hernández Hernández
6ca011430a
do not skip frames if a client is stopped and have a pending resize 2022-12-24 16:44:09 -06:00
Leonardo Hernández Hernández
7eaa01ac1f
Revert "Revert "fix flickering when resizing/spawning windows"" 
This reverts commit 4a32293548.
 2022-12-24 16:44:09 -06:00
Leonardo Hernández Hernández
92e7752203
disable client's scene node after create it (only XDGShell) 
will be enabled when setting up its monitor and arrange it

Bug: https://github.com/djpohly/dwl/issues/306
 2022-12-24 16:44:09 -06:00
Leonardo Hernández Hernández
6682878009
call arrange() or resize() depending on c->isfloating in commitnotify 2022-12-24 16:43:31 -06:00
Leonardo Hernández Hernández
afacc9b0b5
force SSD when creating an xdg_toplevel_decoration object 
Closes: https://github.com/djpohly/dwl/issues/366
Not sure why GLFW apps do not get mapped when we do not tell them the
decoration method
 2022-12-20 21:53:45 -06:00
Leonardo Hernández Hernández
dd9d8d543c
remove selclient() 
selclient() does not work well when dealing newly mapped
clients (specifically those mapped on invisible tags).

This fixes various bugs related to things not working because selclient() would
return NULL.

References: 94c8bd6048
 2022-12-20 21:27:14 -06:00
Leonardo Hernández Hernández
686958a4cc
fix unset fullscreen for all visible clients when mapping a new one 
this also changes our policy about when we unset fullscreen:

dwl will unset fullscreen for clients who share tags (and monitor) with a newly
mapped client, it does not matter if the clients are visible or not
 2022-12-20 21:21:40 -06:00
Leonardo Hernández Hernández
1a3d89e5b2
call checkidleinhibitor() in arrange() and not in focusclient() 2022-12-16 18:54:33 -06:00
Leonardo Hernández Hernández
7b1fe7e5f2
fix checking idle inhibit state 
checking `bypass_surface_visibility` first, could cause that even if the idle
inhibitor is being destroyed it will disable idle tracking

and if we couldn't get its scene tree, then assume that the surface is visible
 2022-12-16 17:37:18 -06:00
Leonardo Hernández Hernández
803a9ba98d
Revert "Revert "Check that inhibitor scene tree is not null"" 
This reverts commit 035bb99d67.

Not checking `tree != NULL` result in a segfault if the surface doesn't have a
role (for example because it is a newly created surface)

Closes: https://github.com/djpohly/dwl/issues/359
 2022-12-16 17:20:59 -06:00
Leonardo Hernández Hernández
94c8bd6048
get sel from focustop() in focusstack() 
Fixes: https://github.com/djpohly/dwl/issues/354
 2022-12-09 20:55:58 -06:00
Leonardo Hernández Hernández
c60f651951
Revert "force line-buffered stdout if stdout is not a tty" 
This reverts commit deb48ff48b.

Fixes: https://github.com/djpohly/dwl/issues/253
 2022-12-09 08:46:22 -06:00
Leonardo Hernández Hernández
98c7adfb3d
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-12-06 14:21:44 -06:00
Leonardo Hernández Hernández
79b051f242
implement ext-session-lock-v1 2022-12-06 14:11:41 -06:00
Leonardo Hernández Hernández
d42a977b5b
Revert "remove unneeded changes in commitnotify()" 
This reverts commit 30c24a53ad.

Bug: https://github.com/djpohly/dwl/issues/349
 2022-12-06 13:59:14 -06:00
Leonardo Hernández Hernández
4a32293548
Revert "fix flickering when resizing/spawning windows" 
This reverts commit 017bb7d752.

Bug: https://github.com/djpohly/dwl/issues/349
 2022-12-06 13:58:56 -06:00
Leonardo Hernández Hernández
9136b6247d
return early if couldn't find the popup's parent 2022-12-06 13:34:35 -06:00
Leonardo Hernández Hernández
19b5d47a9e
fix popups appearing outside the monitor 
and a potentially crash
 2022-12-06 13:31:48 -06:00
Leonardo Hernández Hernández
b5229636a3
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-12-05 23:43:47 -06:00
Leonardo Hernández Hernández
22336612ae
improve type safety of toplevel_from_wlr_surface() 2022-12-05 23:18:02 -06:00
Leonardo Hernández Hernández
38bd00351a
merge toplevel_from_{wlr_layer_surface,popup} into client_from_wlr_surface 
now it is a big function called toplevel_from_wlr_surface
 2022-12-05 23:18:01 -06:00
Leonardo Hernández Hernández
13b929d7d7
remove unneeded call to wlr_scene_rect_set_color() 
wlr_scene_rect_create() requires a color as parameter
 2022-12-05 23:06:53 -06:00
Leonardo Hernández Hernández
b6d6127733
add option for set button map 2022-12-05 22:22:49 -06:00
Leonardo Hernández Hernández
02c257e0b1
update for wlroots!3627 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3627
 2022-12-05 20:21:38 -06:00
Dima Krasner
16a49e9955 fix null deref in sigchld() if Xwayland is disabled 2022-12-03 13:30:30 -06:00
Palanix
30c24a53ad
remove unneeded changes in commitnotify() 2022-12-03 13:14:10 -06:00
Palanix
017bb7d752
fix flickering when resizing/spawning windows 
Fixes: https://github.com/djpohly/dwl/issues/306
 2022-12-03 13:14:10 -06:00
Leonardo Hernández Hernández
fac3b6f2cf
use root surfaces to check idle inhibitors 
References: https://github.com/djpohly/dwl/pull/343
 2022-12-02 23:25:46 -06:00
Leonardo Hernández Hernández
035bb99d67
Revert "Check that inhibitor scene tree is not null" 
This reverts commit 9c155eefdc.

This commit was applied just a workaround, the proper fix is the next commit
 2022-12-02 23:25:04 -06:00
Leonardo Hernández Hernández
27ab9cf1b1
call updatemons() in requestmonstate() 
This way we make sure that the Monitor's boxes are updated correctly
 2022-12-02 23:17:05 -06:00
Ben Jargowsky
9c155eefdc Check that inhibitor scene tree is not null 2022-12-02 15:10:25 -06:00
Leonardo Hernández Hernández
1b39bbf316
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-12-02 10:39:06 -06:00
Leonardo Hernández Hernández
eaf8a21603
unset fullscreen when mapping a client in the same monitor 
Fixes: https://github.com/djpohly/dwl/issues/327
 2022-12-02 10:09:50 -06:00
Leonardo Hernández Hernández
ce1d040586
Merge branch 'main' of github.com:djpohly/dwl 2022-12-02 10:06:40 -06:00
Leonardo Hernández Hernández
6df6781b43
simplify check for surface's node state 
all `struct wlr_surface` should have a `wlr_scene_tree *` as data
 2022-11-30 18:54:54 -06:00
Leonardo Hernández Hernández
10c56d6348
add option to allow invisible surfaces to disable idle tracking 2022-11-30 18:51:35 -06:00
Leonardo Hernández Hernández
c91d21b68f
do not move/resize if grabbed client is fullscreen 2022-11-30 17:54:47 -06:00
Leonardo Hernández Hernández
3213088aa2
do not try to set the parent's same tags and monitor for xwayland clients 
References: https://github.com/djpohly/dwl/pull/334#issuecomment-1330166324
 2022-11-30 17:42:58 -06:00
krypek
87d87cc404 Fix comparison between signed and unsigned int 
When c->bw is 0, the right side of the MAX functions gets turned into an unsigned integer and that results in -1 being the outcome.
This causes big issues in xwayland clients.
 2022-11-25 12:09:35 -06:00
Leonardo Hernández Hernández
ea1b2dda63
Merge branch 'main' into wlroots-next 2022-11-21 20:51:30 -06:00
Leonardo Hernández Hernández
087373698a
Revert "Add a configuration option for fullscreen locking" 
now all fullcreen clients are rendered above tiled and floating clients

This partially reverts commit 326eee1444.
 2022-11-21 20:50:39 -06:00
Leonardo Hernández Hernández
caec566286
create a dedicated layer for fullscreen clients 
Bug: https://github.com/djpohly/dwl/issues/327
 2022-11-21 20:50:26 -06:00
Leonardo Hernández Hernández
05eca0e2d9
rename xwayland_surface to xsurface 
this save us 2 lines
 2022-11-21 14:28:05 -06:00
Leonardo Hernández Hernández
7eebe67787
set x and y of the layersurface's geometry box 2022-11-21 14:28:05 -06:00
Leonardo Hernández Hernández
63d6de5866
fix set of layersurface->popups and surface->data 2022-11-21 14:28:04 -06:00
Leonardo Hernández Hernández
60a98b87f3
inhibit idle if surface's node is enabled 2022-11-21 14:28:04 -06:00
Leonardo Hernández Hernández
93a911d6e9
simplify if expression in checkidleinhibitor() 2022-11-21 14:28:04 -06:00
Leonardo Hernández Hernández
88d386bfdc
configurex11: resize floating clients and arrange tiled clients' monitor 2022-11-21 14:27:57 -06:00
Leonardo Hernández Hernández
972e3f3050
Merge branch 'wlroots-next' into main 2022-11-21 14:16:55 -06:00
Leonardo Hernández Hernández
569f554016
don't unfocus focused client when starting a drag 
this fix chromium keyboard focus loss after a drag
Fix: 3cc22de712
 2022-11-19 01:34:15 -06:00
Leonardo Hernández Hernández
21ef004886
listen to the output request_state event; 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/2693
 2022-11-15 23:52:21 -06:00
Leonardo Hernández Hernández
dae00caadd
update for wlroots!3861 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3861
 2022-11-15 23:07:45 -06:00
Leonardo Hernández Hernández
5eb3529275
use the new scene helper for drag icons 2022-11-15 23:07:21 -06:00
Leonardo Hernández Hernández
359e7edc52
update for wlroots!3814 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3814
 2022-11-15 23:04:39 -06:00
Leonardo Hernández Hernández
25dfdcc433
specify layer shell version 2022-11-15 23:04:02 -06:00
Leonardo Hernández Hernández
fcb3fa4e90
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-11-10 23:25:48 -06:00
shua
f1639ba9d5
check null in toplevel_from_popup 
managed to SEGFAULT the server by trying to create a popup
without setting a parent first.

Not sure if this is dwl or wlroots issue, so also opened a ticket upstream: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3811
 2022-11-09 00:01:50 -06:00
Leonardo Hernández Hernández
8bd3442575
layersurface: create a dedicated scene tree for popups 
this tree should be always above the top layer

Fixes: https://github.com/djpohly/dwl/issues/328
 2022-11-01 12:52:25 -06:00
Leonardo Hernández Hernández
3cc22de712
client: don't change border color during drags 
Fixes: https://github.com/djpohly/dwl/issues/318
 2022-10-31 23:46:02 -06:00
Leonardo Hernández Hernández
448a96de13
remove now unneeded workaround in outputmgrapplyortest() 2022-10-30 01:03:44 -05:00
Leonardo Hernández Hernández
99f062273e
only destroy monitor's layer surfaces at destroy 2022-10-29 19:02:44 -05:00
Leonardo Hernández Hernández
8298f20a71
allow change adaptive sync in outputmgrapplyortest() 2022-10-29 18:30:09 -05:00
Leonardo Hernández Hernández
6a0ec2a8c3
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-10-29 18:11:28 -05:00
Leonardo Hernández Hernández
846ce52b92 fix crash in dirtomon() when selmon is disabled 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández
a9e2ebaf41 closemon() now updates selmon if needed 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández
9b5f0f0fc5 use just one loop in outputmgrapplyortest() 
we do the magic in updatemons()
 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández
cb01ce9bcf move focus and clients off disabled monitors 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández
9588b46b5c
only raise the client's node in monocle() 
Fixes: https://github.com/djpohly/dwl/issues/326
 2022-10-29 16:47:17 -05:00
Leonardo Hernández Hernández
1eeb3689d3
add support for the ext-idle-notify-v1 protocol 
for now we use macros to support both KDE idle and ext-idle, wlroots will
likely drop support for KDE idle in 0.17
 2022-10-23 14:41:28 -05:00
Leonardo Hernández Hernández
e9826de295
Revert "stop trying resize clients during commitnotify()" 
This reverts commit 2d9d758c8d.

wasn't meant to be pushed to main
 2022-10-15 18:25:58 -05:00
Leonardo Hernández Hernández
110cde8f67
update comment about exclusive focus in focusclient() 2022-10-15 18:09:42 -05:00
Leonardo Hernández Hernández
2d9d758c8d
stop trying resize clients during commitnotify() 
instead resize them in configurex11()
 2022-10-15 18:00:55 -05:00
Leonardo Hernández Hernández
332ceb7136 allow unmanaged clients (like dzen or dmenu) to have keyboard focus 2022-10-15 18:00:24 -05:00
Leonardo Hernández Hernández
4eabf6f7eb
disable and destroy monitor's layer surfaces when it's being destroyed 
Fixes: https://github.com/djpohly/dwl/issues/314
 2022-10-11 13:11:14 -05:00
Leonardo Hernández Hernández
765656902f
use /* */ for comments in applybounds() 2022-10-08 20:51:40 -05:00
Leonardo Hernández Hernández
1438dfc150
fix bad indentation in createpointer() 2022-10-08 20:51:05 -05:00
Leonardo Hernández Hernández
3902fba769
rename dragicondestroy() -> destroydragicon() 
to match the rest of the code
 2022-10-08 20:50:17 -05:00
Leonardo Hernández Hernández
7f3c9fa0ae
rename LyrNoFocus -> LyrDragIcon 2022-10-08 20:48:48 -05:00
Leonardo Hernández Hernández
952fde68a3
correctly handle cursor motion when button is held (for layer surfaces) 2022-10-08 13:02:43 -05:00
Dima Krasner
0d1ca4663c
allow moveresize() while the left mouse button is pressed 
Fixes: https://github.com/djpohly/dwl/issues/319
 2022-10-08 12:31:29 -05:00
Leonardo Hernández Hernández
f6820a6c29
fix drag and drop not working 
this fixes another issue where the cursor doesn't change when selecting text
but there is still an issue about not changing border color of clients during
dnd operations

Bug: https://github.com/djpohly/dwl/issues/318
 2022-10-07 10:45:45 -05:00
Leonardo Hernández Hernández
8559141b30
avoid usage of goto 
Based on this suggestion: bc72af6e24 (commitcomment-85592855)
 2022-10-03 23:28:58 -05:00
Leonardo Hernández Hernández
434ed119f3
wlroots check map state of layersurfaces this for us 2022-10-01 23:33:17 -05:00
Leonardo Hernández Hernández
ae3d435717
Merge remote-tracking branch 'djpohly/main' into wlroots-next 2022-10-01 23:30:47 -05:00
Leonardo Hernández Hernández
b8bc54b65d properly handle cursor motion when button is held 
Based on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3653
 2022-10-01 23:10:54 -05:00
Leonardo Hernández Hernández
b5776e5180
avoid setting duplicate cursor image 
Reference: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3436
Based on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3595
 2022-09-28 17:11:04 -05:00
Leonardo Hernández Hernández
c13d948ea9
destroy renderer and allocator in cleanup() 2022-09-28 14:15:25 -05:00
Leonardo Hernández Hernández
fc8b2a8335
fix bad condition 2022-09-26 20:31:36 -05:00
Leonardo Hernández Hernández
c00faae263
fix various segfaults when selmon is NULL 2022-09-26 19:07:45 -05:00
Leonardo Hernández Hernández
e46238b95e
change cursor surface in internal calls of motionnotify() 
and call motionnotify() after unmapping a client
and when focusing a client

Fixes: https://github.com/djpohly/dwl/issues/308
 2022-09-26 13:17:07 -05:00
Leonardo Hernández Hernández
2385d82612
remove unused variables 2022-09-20 23:40:35 -05:00
Leonardo Hernández Hernández
1fdc65ff93
make more permissive exclusive focus 
now you can call focusstack() while a layer surface is focused and when it gets
unmapped the newly focused clients will be actually focused
 2022-09-18 17:25:12 -05:00
Leonardo Hernández Hernández
fbaeb85363
now really fix clients not being focused after unmapping a layer surface 2022-09-18 17:23:07 -05:00
Leonardo Hernández Hernández
570e6e2c27
fix clients not being focused after destroy a layer surface 2022-09-18 16:52:54 -05:00
Leonardo Hernández Hernández
a1b33826cf
Revert "remove useless check of m in arrangelayers()" 
This partially reverts commit d14ee99661.

Checking if the output is enabled is necessary to avoid a segfault later
 2022-09-18 16:36:38 -05:00
Leonardo Hernández Hernández
d14ee99661
remove useless check of m in arrangelayers() 
it is supossed to avoid a crash when we pass m=NULL as argument
however it would crash anyway and also because we should not pass m=NULL
 2022-09-18 15:35:54 -05:00
Leonardo Hernández Hernández
cd96f889b8
fix use of loop initial declaration 
forbidden by the suckless style
 2022-09-18 15:35:54 -05:00
Leonardo Hernández Hernández
bc72af6e24
fix unmanaged clients not being unlinked from the commit listener 2022-09-18 15:35:54 -05:00
Leonardo Hernández Hernández
bcc8ce7a40
fix segfault when unlocking swaylock on two monitor setup 
wlr_*_surface_from_wlr_surface() can return NULL if the surface
is being destroyed

Fixes: https://github.com/djpohly/dwl/issues/305
 2022-09-18 15:35:54 -05:00
Leonardo Hernández Hernández
ba7dcb2dea
don't try to move outputs when its x,y hasn't change 
when using wlr_output_layout_move() wlroots internally
change the state of the output to manually configured and
when updating the layout these outputs aren't ignored by
wlroots, leaving us at our own
 2022-09-10 23:54:57 -05:00
Leonardo Hernández Hernández
c8a9f63451
prior run the startup command start the backend 
this allow use clients like wlr-randr in the startup command
 2022-09-10 23:54:56 -05:00
Leonardo Hernández Hernández
fd67087a82
make sure the parent is mapped prior set monitor and tags 2022-09-10 23:45:14 -05:00
Leonardo Hernández Hernández
77ba8e5127
use wl_container_of() instead of data in some functions 2022-09-10 23:44:19 -05:00
Leonardo Hernández Hernández
c509046663
add some comments 2022-09-10 23:42:58 -05:00
Leonardo Hernández Hernández
93de6e82a2
inline input_device in virtualkeyboard() 2022-09-10 22:25:46 -05:00
Leonardo Hernández Hernández
f8f94c97f5
fix idle inhibitor check 
previously we tried to get a client from the surface and then compare it with
the excluded surface, if we cannot get a client from the surface (e.g: a layer
surface) it just ignored all the next idle inhibitors no matter what

What I have should done is just checking if the excluded surface is equal to
the current idle inhibitor's surface and continue in case it is.
 2022-09-10 22:11:06 -05:00
Leonardo Hernández Hernández
1bb9c4583a
fix exclusive zone of unmapped layer surfaces 
Fixes: https://github.com/djpohly/dwl/issues/302
 2022-09-10 18:54:35 -05:00
Leonardo Hernández Hernández
9bcef3d040
resize the fullscreen background when resize the client 2022-09-08 16:35:55 -05:00
Leonardo Hernández Hernández
871463c327
define _POSIX_C_SOURCE through CPPFLAGS 
like dwm
 2022-09-08 00:10:53 -05:00
Leonardo Hernández Hernández
d1496a2a9b
fix condition that always evaluate to false in commitlayersurfacenotify() 2022-09-07 23:54:57 -05:00
Leonardo Hernández Hernández
80084839a9
remove obsolete check of c->mon in fullscreennotify() 
since 19a8a095eb it's checked in setfullscreen()
 2022-09-07 23:24:50 -05:00
Leonardo Hernández Hernández
1aacfada29
set c->prev in setmon() and not in mapnotify() 2022-09-06 13:23:19 -05:00
Leonardo Hernández Hernández
dc59f7733d
enable adaptive sync if supported 
but don't cause monitors to be ignored if it fails
 2022-09-06 00:35:20 -05:00
Leonardo Hernández Hernández
14c010a0d6
only enable/disable clients from the specified monitor in arrange() 
also fix a crash when m is null, this can only happen when selmon is NULL
 2022-09-06 00:10:00 -05:00
Leonardo Hernández Hernández
14a1e3e2a2
set c->prev in mapnotify() 
Closes: #300
 2022-09-05 16:35:51 -05:00
Leonardo Hernández Hernández
68576799b9
don't arrange layers on disabled monitors 2022-09-02 18:49:20 -05:00
Leonardo Hernández Hernández
19a8a095eb
call setfullscreen() in setmon() 
this will help when sending to another monitor a fullscreen client
and also will prevent a crash when a client request fullscreen when it has no monitor
 2022-09-02 18:22:15 -05:00
Leonardo Hernández Hernández
1f59b76d77
prevent segfault when destroying monitors 
also don't count unmapped surfaces for exclusive zone
and exclusive_focus is now of type `void *`
 2022-09-02 18:17:53 -05:00
Leonardo Hernández Hernández
40b1c0b849
Revert "Revert "various improvements to layer surface"" 
This reverts commit c017916d35.
 2022-09-02 16:54:53 -05:00
Leonardo Hernández Hernández
c017916d35
Revert "various improvements to layer surface" 
see https://github.com/djpohly/dwl/issues/289#issuecomment-1231287114

This reverts commit 2260519740.
 2022-08-31 16:05:19 -05:00
Leonardo Hernández Hernández
2260519740 various improvements to layer surface 
- remove various useless assignments of layersurface->mon
- styles changes
- do not set wlr_layer_surface->output to NULL at destroy
 2022-08-29 21:32:59 -05:00
Leonardo Hernández Hernández
0e993b5fb1
conform the idle inhibitor protocol 
previously we disable idle tracking simply due to the fact that it exist
 2022-08-28 22:40:11 -05:00
Leonardo Hernández Hernández
83e37820d7
add support for the single pixel buffer protocol 2022-08-28 22:15:57 -05:00
Leonardo Hernández Hernández
d738573e22
new function to notify keyboard enter 2022-08-27 16:34:29 -05:00
Leonardo Hernández Hernández
e0cc5b046c
Merge remote-tracking branch 'djpohly/main' into wlroots-next 2022-08-26 18:26:36 -05:00
Leonardo Hernández Hernández
406aebcbd2
prevent an infinite loop if try to use focusmon() with all monitors disabled 2022-08-25 00:20:21 -05:00
Leonardo Hernández Hernández
dfcd142ce4
don't try to set monitor for clients in createmon() 
this is done in updatemons()
 2022-08-23 13:29:12 -05:00
Leonardo Hernández Hernández
07bf1832bf
set monitor for clients that don't have one in updatemons() 
only if selmon is enabled and the clients are mapped
 2022-08-23 13:28:01 -05:00
Leonardo Hernández Hernández
174919ec53
set monitor for clients that don't have one on monitor creation 2022-08-18 16:55:13 -05:00
Leonardo Hernández Hernández
a7f77160d1
don't respect size hints for fullscreen clients 
Fixes: #292
 2022-08-16 21:39:42 -05:00
Leonardo Hernández Hernández
7a343b98cf
change type of c->bw: int -> unsigned int 2022-08-13 00:41:08 -05:00
Leonardo Hernández Hernández
8d2516e83c
reorder isfullscreen in Client definition 2022-08-13 00:38:08 -05:00
Leonardo Hernández Hernández
f173c56c32
initialize to zero the box used in commitnotify() 2022-08-13 00:12:46 -05:00
Leonardo Hernández Hernández
48396a1bf8 fix crash when setting a custom mode 2022-08-12 23:21:25 -05:00
Leonardo Hernández Hernández
b6e3fc1645 rework outputmgrapplyortest() 
first disable requested monitors, then enable and/or change mode, x and y, etc.
This is mostly what sway does
 2022-08-12 23:21:25 -05:00
Leonardo Hernández Hernández
662e06e68e
check client_from_wlr_surface() returning NULL in urgent() 
fix #281
 2022-07-30 14:44:17 -05:00
Dima Krasner
9d2eb8483b fix segfault if parent->mon is unset 2022-07-25 01:19:36 -05:00
Leonardo Hernández Hernández
7eee0a8229
use the layer surface to create popups 2022-07-24 16:43:13 -05:00
Leonardo Hernández Hernández
b04c73be3d
make sure we do not create a double fullscreen_bg 
and also make sure we do not destroy it if it does not exist
Fixes: #274
 2022-07-23 13:28:15 -05:00
Leonardo Hernández Hernández
8cdb997126
conform the xdg-protocol with fullscreen translucent clients 
see `setfullscreen()` for more info
 2022-07-23 02:17:00 -05:00
Leonardo Hernández Hernández
90a12c90a0
always set the same monitor and tags for child clients of a client 
fixes #272
 2022-07-19 20:13:56 -05:00
Leonardo Hernández Hernández
e082292606
do not focus clients if a layer surface is focused 2022-07-19 12:24:24 -05:00
Dima Krasner
deb48ff48b force line-buffered stdout if stdout is not a tty 2022-07-19 12:18:16 -05:00
Leonardo Hernández Hernández
c70db2d06a
Revert "only call wlr_seat_keyboard_notify_enter() if a keyboard is found" 
This reverts commit 8e03bce621.
fixes #270
 2022-07-19 11:52:42 -05:00
Leonardo Hernández Hernández
8e03bce621
only call wlr_seat_keyboard_notify_enter() if a keyboard is found 2022-07-07 00:21:51 -05:00
Leonardo Hernández Hernández
87fc3a58ab
check pointer focus in arrange() 2022-07-06 23:48:53 -05:00
Leonardo Hernández Hernández
c6d97f1db7
arrange client's monitor if size has change since last commit 2022-07-06 22:20:21 -05:00
Leonardo Hernández Hernández
829dec6598
resize now takes struct wlr_box as parameter 2022-07-06 22:18:46 -05:00
Leonardo Hernández Hernández
ff70337c16
check current and pending geometry to set c->resize to zero 
Fixes #260
 2022-07-06 22:16:00 -05:00
Ben Jargowsky
7cc6c640e2 Checks for overflows for client max width and height 2022-06-29 00:35:06 +02:00
Leonardo Hernández Hernández
72e0a560d9
respect size hints 2022-06-24 19:19:20 -05:00
Leonardo Hernández Hernández
2aa391361c
inline unmaplayersurface() into unmaplayersurfacenotify() 
unmap signal is guaranted to be emitted before destroy signal
so is useless checking if it is mapped at destroy
 2022-06-24 15:36:13 -05:00
Leonardo Hernández Hernández
549335ae54
avoid layer surface popups appearing below x{dg,wayland} clients 2022-06-24 14:46:08 -05:00
Leonardo Hernández Hernández
097b4a30f5
unconstrain layer shell popups from monitor size 
unconstrain other popups from monitor usable area
 2022-06-24 14:30:52 -05:00
Leonardo Hernández Hernández
461d02d3e0
chase wlroots input_device changes 2022-06-21 16:25:18 -05:00
Leonardo Hernández Hernández
c1578bc14d
use LayerSurface.mon when possible 2022-06-21 16:03:20 -05:00
Leonardo Hernández Hernández
9b84940e37
unconstrain layer shell popups 
also unconstrain popups from monitor's usable area
 2022-06-21 00:23:21 -05:00
Leonardo Hernández Hernández
79ad72413d
don't set c->isfullscreen to zero 
calloc initializes all fields to zero
 2022-06-20 18:05:16 -05:00
Leonardo Hernández Hernández
4ae6d0f387
move ugglyness to client.h 2022-06-16 15:54:13 -05:00
Leonardo Hernández Hernández
2ef5abfb72
remove unneeded check in focusclient() 2022-06-16 15:36:27 -05:00
Leonardo Hernández Hernández
d26ddfc7fd
kill child process in cleanup() 2022-06-14 15:31:39 -05:00
Marco Siedentopf
8bce3b1583
add click method configuration option 
Add the libinput configuration option to choose between Software Button Areas and Clickfinger
 2022-06-10 12:27:40 -05:00
Leonardo Hernández Hernández
a32db11f16
set client bounds at resize 2022-06-09 12:45:42 -05:00
Leonardo Hernández Hernández
948fdcf709
use xdg-shell v4 2022-06-09 12:45:02 -05:00
Leonardo Hernández Hernández
4b890336e2
use xdg-shell v3 2022-06-07 00:55:41 -05:00
Leonardo Hernández Hernández
c7007b4811
chase wlroots scene-tree changes 2022-06-07 00:31:58 -05:00
Leonardo Hernández Hernández
4dfa45659a
fix compiler error with gcc complaining about parentheses 
dwl.c: In function ‘unmaplayersurface’:
dwl.c:2253:9: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
 2253 |         layersurface->layer_surface->mapped = layersurface->mapped = 0;
      |         ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [<builtin>: dwl.o] Error 1

clang not affected
 2022-06-05 16:57:20 -05:00
Leonardo Hernández Hernández
b91017e713
disable scene node at unmaplayersurface() 2022-06-05 15:27:40 -05:00
Leonardo Hernández Hernández
2623a96ebf
call client_set-size() if client has a resize 2022-05-27 00:19:17 -05:00
Leonardo Hernández Hernández
52e0d00942
check client_surface() returning NULL 
now client_surface()->data is a pointer to the wlr_scene_tree of clients
which allows us to not call wlr_scene_node_lower_to_bottom() for every clients
 2022-05-25 17:12:44 -05:00
Leonardo Hernández Hernández
7018b9b65c
correct libinput function name for drag_lock 2022-05-25 15:01:38 -05:00
Leonardo Hernández Hernández
48ec914f43
destroy layersurface's scene node in destroylayersurfacenotify() 2022-05-25 14:49:32 -05:00
Leonardo Hernández Hernández
40449fa64f
add a new function to get a client from a wlr_surface 2022-05-23 10:55:28 -05:00
Ben Jargowsky
ecbc2c61db Add configuration options for touchpads 2022-05-23 00:01:47 +02:00
Leonardo Hernández Hernández
283c043b5c
chase wlroots scene-surface refactor 2022-05-21 20:44:08 -05:00
Leonardo Hernández Hernández
88a8b784d0
Merge remote-tracking branch 'djpohly/main' into wlroots-next 
chase wlroots X11 hints update
 2022-05-17 15:31:31 -05:00
Leonardo Hernández Hernández
8870ba0bb8
implement urgency hints for xwayland clients 2022-05-17 14:38:18 -05:00
Leonardo Hernández Hernández
79a148224f
specify version in wlr_xdg_shell_create() 2022-05-15 17:17:58 -05:00
Leonardo Hernández Hernández
3c11ad9aa6
fix segfault when dragging chromium tabs 2022-05-14 00:29:35 -05:00
Ben Jargowsky
06d9230a96 Run focusclient when switching to monocle layout 2022-05-13 10:20:28 +02:00
Leonardo Hernández Hernández
dca68f9aa1
Merge remote-tracking branch 'djpohly/main' into wlroots-next 2022-05-10 20:08:41 -05:00
Leonardo Hernández Hernández
22bd75226b
remove trailing whitespaces 2022-05-10 11:42:40 -05:00
Leonardo Hernández Hernández
063736f898
add -v flag to the manpage 
Thanks @Humm42
 2022-05-10 11:39:33 -05:00
Leonardo Hernández Hernández
5d8084daa7
add flag to print version and exit 2022-05-09 16:24:36 -05:00
Ben Jargowsky
e0d310fd84 Handle 'wlr_seat_get_keyboard' possibly returning null. 2022-05-09 14:00:21 +02:00
Leonardo Hernández Hernández
3a4b7d104f
restack xwayland surface on focusclient() 2022-04-29 17:45:02 -05:00
Ben Jargowsky
d071a899f3 Run printstatus() when a monitor is removed 2022-04-25 13:50:53 -07:00
Leonardo Hernández Hernández
dc7709a00e
schedule a configure on maximize request 
see maximizenotify() for more info
 2022-04-16 15:51:13 -05:00
Leonardo Hernández Hernández
a48ce99e6a
use pointer math in xytonode() 2022-04-15 17:40:02 -05:00
Leonardo Hernández Hernández
4a2e761914
replace deleted EBARF() with die() 2022-04-12 23:52:05 -05:00
Leonardo Hernández Hernández
29a2b647b2
Merge remote-tracking branch 'djpohly/main' into HEAD 2022-04-08 21:12:32 -05:00
Leonardo Hernández Hernández
c00697e643
abc 2022-04-05 23:04:04 -05:00
Leonardo Hernández Hernández
af741e586b
typedefs: abc 2022-04-05 22:15:46 -05:00
Leonardo Hernández Hernández
02ac9378c4
includes: abc 2022-04-05 22:07:59 -05:00
Devin J. Pohly
720f56161e Remove vestigial monitor configuration info 
The x/y fields in monitor rules are unused and were meant to be deleted.
Also removes the outdated comment in config.h.
 2022-04-03 00:01:52 -05:00
Leonardo Hernández Hernández
4d3adea683
die on pipe failure 2022-03-31 15:32:30 -06:00
Raphael Robatsch
79b7e755b0
Layer shell: Prevent infinte configure/commit loop 
Check the wlr_layer_surface_v1_state.committed bitmask to see if we need
to rearrange. This is also what sway does.

Without this check, every commit request (even if only the attached buffer
changed) will lead to another configure event, which will lead to another
commit, etc.

This loop results in swaybg consuming 100% CPU.

Co-authored-by: Owen Rafferty <owen@owenrafferty.com>
 2022-03-31 15:27:13 -06:00
Devin J. Pohly
0ddde0c85a move sigchld() into XWayland section 2022-03-29 16:09:29 -05:00
Devin J. Pohly
e08bd12922 make sure to leave XWayland process waitable 
On SIGCHLD, check to make sure the terminated process is not the
XWayland process before reaping it, allowing wlroots to waitpid() for it
successfully.

Fixes #177.
 2022-03-29 15:55:06 -05:00
Leonardo Hernández Hernández
aab397c30b
new functions ecalloc() and die() 
die() replaces EBARF and BARF
and allow us to add `-pedantic` to CFLAGS
 2022-03-28 15:02:09 -06:00
Leonardo Hernández Hernández
7018ed9218
createpointer now takes wlr_pointer 2022-03-25 15:27:36 -06:00